Project

General

Profile

Actions

Task #67201

closed

[count|get][Folders|Files] do same twice for every FAL list request

Added by Alexander Opitz almost 9 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2015-05-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

For listing files/folders we call first count and then get. Both functions call retrieveFileAndFoldersInPath which now runs twice inclusive sorting afterwards.

Disabling sorting on count would be easy to work out, but do we really need retrieve twice for folder and twice for file?

Actions #1

Updated by Michael Oehlhof almost 9 years ago

The countFilesInFolder and countFoldersInFolder functions are calling the corresponding get* functions internally. We could cache the result of the get* functions during runtime of the script to prevent calling the get* functions twice.

Actions #2

Updated by Michael Oehlhof almost 9 years ago

  • Assignee set to Michael Oehlhof
Actions #3

Updated by Michael Oehlhof almost 9 years ago

  • Sprint Focus set to Remote Sprint
Actions #4

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40871

Actions #5

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40871

Actions #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40871

Actions #7

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40871

Actions #8

Updated by Susanne Moog over 8 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #9

Updated by Benni Mack over 8 years ago

  • Target version changed from 7.5 to 7 LTS
Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40871

Actions #11

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40871

Actions #12

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40871

Actions #13

Updated by Markus Klein over 6 years ago

  • Status changed from Under Review to New
  • Assignee deleted (Michael Oehlhof)
  • Target version deleted (7 LTS)
  • Complexity set to hard
  • Sprint Focus deleted (Remote Sprint)

The patch has been abandoned.

Actions #14

Updated by Susanne Moog about 5 years ago

  • Status changed from New to Closed

As this is a technical task, the patch has been abandoned because we could not come up with a good conceptional solution and no one has worked on it for multiple years, I'm going to close the issue now. If anyone has an idea on how to implement this in a sensible way and can provide performance statistics, please push a new patch, the ticket will reopen automatically.

Actions

Also available in: Atom PDF