Project

General

Profile

Actions

Bug #68430

closed

Overwriting labels by TypoScript not possible for all labels in indexed search (experimental mode)

Added by Gerhard Rupp almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Indexed Search
Target version:
Start date:
2015-07-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

The labels in locallang.xml contain dots following a number. This prohibits the change of texts via TS.

The labels should be changed so that they contain underscores instead of dots (as it is in pi-based version).
An example how to change the texts should be included in the manual.

For exapmle:

pi-based: "opt_freeIndexUid_header_0"
Extbased: "indexingConfigurationHeader.0"

Btw: Translating "result.noResult" via TS is no problem

Escaping the dot in the TS does not resolve the issue.

Actions #1

Updated by Markus Klein almost 9 years ago

  • Target version changed from 6.2.15 to 7.4 (Backend)
  • Sprint Focus set to Stabilization Sprint

Hm... instead of changing the labels, we should change the translation logic, because we have hundreds of labels with dot notation nowadays.

Actions #2

Updated by Gerhard Rupp almost 9 years ago

The "original" indexed search (pi-based) did have different labels which did not contain the dots. So labels already were changed.

Btw. as already stated a dot is only a problem if followed by a number.

Actions #3

Updated by Markus Klein almost 9 years ago

I'll take a look into the unittests of the TypoScriptParser if that case is covered properly.

Actions #4

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41834

Actions #5

Updated by Markus Klein almost 9 years ago

Testing instructions.

  1. add the "experimental" plugin to a page
  2. add the static template for indexed_search
  3. add TS like plugin.tx_indexedsearch._LOCAL_LANG.default.searchTypes\.1 = asdf
  4. open FE and use advanced search.
Actions #6

Updated by Markus Klein almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41841

Actions #8

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41841

Actions #9

Updated by Markus Klein almost 9 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF