Project

General

Profile

Actions

Bug #68606

closed

copyRecords removes NULL values from original data

Added by Jo Hasenau over 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2015-07-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

While doing a copy & paste of a record after another record the method copyRecord makes use of some values of the target record.
These values are coming from fields that can be defined in TCA so basically there can be any field of any type and configuration as a source for such a value.
This works perfectly fine unless the value is NULL, which is a rare case in TYPO3 but can happen already.

While preparing the structured content stuff I noticed that necessary NULL values in colPos fields got replaced with 0.
This is due to the fact that copyRecords uses isset(), which returns FALSE for NULL values, where array_key_exists() would be the way to go.

Since this is not just a problem of structured content, I would like to fix that within a separate patch, to make sure the method as such is working as expected.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #69948: Warnings in DataHandler on undefined array indexesClosedOliver Hader2015-09-18

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42081

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42081

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42081

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42081

Actions #5

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #6

Updated by Jo Hasenau over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF