Task #68973

Story #68805: Replace current icons in the core by using the new Icon-API

Replace icon by the IconFactory actions-reference-file

Added by Markus Günther about 4 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2015-08-07
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Register the icon "actions-reference-file" and replace the iconUtility calls for that icon with the IconFactory.

The icon actions-reference-file is still a image icon. Need to wait for the SVG!


Related issues

Precedes TYPO3 Core - Task #69737: CLEANUP usage of status-status-reference-hard Closed 2015-09-12

Associated revisions

Revision aacfd2ba (diff)
Added by Jan Helke about 4 years ago

[TASK] Replace icon by IconFactory: actions-reference-file

As the icon was missing even before this patch and the function is
only be called in the case of an import from TYPO3 4.5 I took the
liberty to just replace it with the reference-hard icon, to which
it is connected.

Releases: master
Resolves: #68973
Change-Id: I8144379444492aab28c5ae7ec19408c26bb949a3
Reviewed-on: http://review.typo3.org/43234
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Morton Jonuschat about 4 years ago

  • Subject changed from Replace icon by the IconFactory actions-insert-reference to Replace icon by the IconFactory actions-reference-file
  • Description updated (diff)

#68973 and #68974 were identical, but the issue for „actions-reference-file“ was missing.

#2 Updated by Morton Jonuschat about 4 years ago

  • Assignee set to Morton Jonuschat

#3 Updated by Morton Jonuschat about 4 years ago

  • Status changed from New to Needs Feedback

Seem the icon file and the associated CSS is missing. The icon is referenced in EXT:impexp

#4 Updated by Frank Naegler about 4 years ago

I think we should simple remove it.

#5 Updated by Jan Helke about 4 years ago

The only way to test that is to copy typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/PagesAndTtContentWithRteImagesAndFileLink/ImportExportXml/pages-and-ttcontent-with-rte-image-n-file-link.xml to fileadmin/user_upload/_temp_/importexport and try to import that.
Than the icon in front of " RTEmagicP_typo3_image2.jpg (Original)" is the icon in question. Yes, it is already missing. But as I would not remove that, because it might be possible that someone will import old 4.5 stuff, I will push a patch for that.

#6 Updated by Gerrit Code Review about 4 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43234

#7 Updated by Jan Helke about 4 years ago

  • Assignee changed from Morton Jonuschat to Jan Helke

#8 Updated by Jan Helke about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF