Task #69261

Reduce PageLayoutController and PageLayoutView dependencies

Added by Oliver Hader over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2015-08-22
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:

Description

This is a follow-up to #68395 to reduce complexity and exposed public API of that change.

Even if class components have the names "controller" and "view", which implies an underlying MVC-stack, the PageLayout components are far from using the pattern. That's why it's quite fine to put processing logic to the place where it makes most sense and where dependencies and cross-calls to other objects are kept low.

This change is only about refactoring and reducing the public API in terms of information hiding and encapsulation.
Besides that the $languagesInColumnCache class variable was defined but never use - which is changed now as well.
Further flaws concerning proper record selection are part of another change.


Related issues

Related to TYPO3 Core - Task #68395: Make CE copy action more flexible Closed 2015-07-20

Associated revisions

Revision f83295f0 (diff)
Added by Oliver Hader about 4 years ago

[TASK] Reduce PageLayoutController and PageLayoutView dependencies

This is a follow-up to #68395 to reduce complexity and exposed
public API of that change.

Even if class components have the names "controller" and "view",
which implies an underlying MVC-stack, the PageLayout components
are far from using the pattern. That's why it's quite fine to put
processing logic to the place where it makes most sense and where
dependencies and cross-calls to other objects are kept low.

This change is only about refactoring and reducing the public API
in terms of information hiding and encapsulation. Besides that
the $languagesInColumnCache class variable was defined but never
use - which is changed now as well. Further flaws concerning
proper record selection are part of another change.

Related: #68395
Resolves: #69261
Releases: master
Change-Id: I8bb7737d154a5d2c7a584dbe11fd0a5abfabafba
Reviewed-on: http://review.typo3.org/42838
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42838

#2 Updated by Oliver Hader about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF