Task #68395

Make CE copy action more flexible

Added by Mathias Schreiber over 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2015-07-20
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Primer

Web -> Page -> Languages
When we have content Elements in the default language a Button called "Copy default content elements (#)" shows up.
This button copies all content elements in this column and sets their `l18n_parent` to the uid of the CE being copied from.

Pro's and Con's

  • Pro
    • Easy to use
    • keeps l18n_parent intact
  • Con
    • No way to copy from a different language
    • keeps l18n_parent intact, thus no way to simply copy, not copy & reference

Keeping l18n_parent intact has some implications because the editor now works on references, rather on independent content.
In general the current way with referenced translations is fine.
But in order to translate independent content from a language, an editor needs to create all content elements again - resulting in a tedious task.

Proposed behavior

The button "copy default content elements (#)" is being replaced with a split button.
The dropdown part of the button contains the following options:
  • Translate from default language
  • Copy from language `Language name` (per Language that has content elements on this page)

If the latter case of copying from a language the content elements are truly copied, so no reference to a parent language will be set.
This will speed up the process for an editor in case the editor needs independent, translated content.


Related issues

Related to TYPO3 Core - Bug #61179: Flaws in copying a page with localized content elements Closed 2014-08-25
Related to TYPO3 Core - Task #69261: Reduce PageLayoutController and PageLayoutView dependencies Closed 2015-08-22

Associated revisions

Revision 5d54869b (diff)
Added by Andreas Fernandez over 4 years ago

[FEATURE] Allow copying from another language

This patch extends the "Copy from default elements" buttons by a dropdown
list of available languages. Clicking one of those languages creates
independent copies (not references!) of the selected language.

Resolves: #68395
Releases: master
Change-Id: I2ce443644ca1fbc6f0c41bc5917515b2784bc155
Reviewed-on: http://review.typo3.org/41768
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision f83295f0 (diff)
Added by Oliver Hader over 4 years ago

[TASK] Reduce PageLayoutController and PageLayoutView dependencies

This is a follow-up to #68395 to reduce complexity and exposed
public API of that change.

Even if class components have the names "controller" and "view",
which implies an underlying MVC-stack, the PageLayout components
are far from using the pattern. That's why it's quite fine to put
processing logic to the place where it makes most sense and where
dependencies and cross-calls to other objects are kept low.

This change is only about refactoring and reducing the public API
in terms of information hiding and encapsulation. Besides that
the $languagesInColumnCache class variable was defined but never
use - which is changed now as well. Further flaws concerning
proper record selection are part of another change.

Related: #68395
Resolves: #69261
Releases: master
Change-Id: I8bb7737d154a5d2c7a584dbe11fd0a5abfabafba
Reviewed-on: http://review.typo3.org/42838
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Mathias Schreiber over 4 years ago

  • Assignee set to Andreas Fernandez

#2 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#11 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41768

#13 Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Oliver Hader over 4 years ago

Using the new copy action means, that the regular overlay handling does not apply (default -> translation) in this case, right?
Thus, the new split button behavior can create translations that have a localization parent (fallback) and those that don't (copied) - these mix-cases leads to the button always being shown...
I'm not sure if I already correctly understood the scope and intention of this change...

#15 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF