Bug #69327

Check if absolute url is used for responsive images

Added by Heiko Kromm almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Content Rendering
Target version:
-
Start date:
2015-08-26
Due date:
% Done:

0%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Creating responsive images adds always absRefPrefix to the image url.
If you use FAL driver like aus_driver_local_cdn. There is an absolute url and prepending absRefPrefix will create a wrong file path.

I created a small patch which resolves this.

contentobject.patch View (1.17 KB) Heiko Kromm, 2015-08-26 12:48


Related issues

Duplicates TYPO3 Core - Bug #69861: Support urls on image processing Closed 2015-09-16

History

#1 Updated by Alexander Opitz almost 5 years ago

  • Status changed from New to Needs Feedback

Hi Heiko,

thanks for the patch, can you push the patch for master into Gerrit?

#2 Updated by Heiko Kromm over 4 years ago

Hi Alexander,

I've never pushed something to gerrit before.
I followed this description: https://forge.typo3.org/projects/9/wiki/Working_with_Gerrit_as_a_Developer
Additionaly I added a ssh-Public-Key to my account on review.typo3.org, but I get a "Fatal: Could not read from remote repository." when I try to push with the following command:

git push ssh://review.typo3.org/Packages/TYPO3.CMS HEAD:refs/for/TYPO3_6-2

Do I need an additional authorization that allows me to push?
Connecting via ssh works.

#3 Updated by Alexander Opitz over 4 years ago

Hi Heiko,

at first a patch should first only be done for master and if this is accepted and merged we will backport it to other versions (like 6.2) if it is a needed bugfix without to much intrusion.

So correctly you should checkout master, patch it and commit. Afterwards push it with

git push origin HEAD:refs/for/master

#4 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42993

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

#8 Updated by Markus Sommer over 4 years ago

  • Assignee set to Heiko Kromm

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

#10 Updated by Alexander Opitz over 4 years ago

  • Status changed from Under Review to Needs Feedback

Is this issue resolved with the patch of #69861 ?

#11 Updated by Morton Jonuschat over 4 years ago

  • Category set to Content Rendering
  • Status changed from Needs Feedback to Resolved

Yes it is, just verified / backported

#12 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF