Bug #69327: Check if absolute url is used for responsive images - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (2)

Alexander Opitz
Heiko Kromm

Actions

Copy link

Bug #69327

closed

Check if absolute url is used for responsive images

Added by Heiko Kromm about 9 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Heiko Kromm

Category:

Content Rendering

Target version:

Start date:

2015-08-26

Due date:

% Done:

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Creating responsive images adds always absRefPrefix to the image url.
If you use FAL driver like aus_driver_local_cdn. There is an absolute url and prepending absRefPrefix will create a wrong file path.

I created a small patch which resolves this.

Files

contentobject.patch (1.17 KB) contentobject.patch

Heiko Kromm, 2015-08-26 12:48

Related issues 1 (0 open — 1 closed)

Is duplicate of TYPO3 Core - Bug #69861: Support urls on image processing

Closed

Nicole Cordes

2015-09-16

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Alexander Opitz about 9 years ago

Status changed from New to Needs Feedback

Hi Heiko,

thanks for the patch, can you push the patch for master into Gerrit?

Actions

Copy link

Updated by Heiko Kromm about 9 years ago

Hi Alexander,

I've never pushed something to gerrit before.
I followed this description: https://forge.typo3.org/projects/9/wiki/Working_with_Gerrit_as_a_Developer
Additionaly I added a ssh-Public-Key to my account on review.typo3.org, but I get a "Fatal: Could not read from remote repository." when I try to push with the following command:

git push ssh://review.typo3.org/Packages/TYPO3.CMS HEAD:refs/for/TYPO3_6-2

Do I need an additional authorization that allows me to push?
Connecting via ssh works.

Actions

Copy link

Updated by Alexander Opitz about 9 years ago

Hi Heiko,

at first a patch should first only be done for master and if this is accepted and merged we will backport it to other versions (like 6.2) if it is a needed bugfix without to much intrusion.

So correctly you should checkout master, patch it and commit. Afterwards push it with

git push origin HEAD:refs/for/master

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42993

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

Actions

Copy link

Updated by Markus Sommer about 9 years ago

Assignee set to Heiko Kromm

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992

Actions

Copy link

#10