Bug #69476

Declaration of TYPO3\CMS\Core\Package\PackageManager::injectClassLoader() should be compatible with TYPO3\Flow\Package\PackageManager::injectClassLoader(TYPO3\Flow\Core\ClassLoader $classLoader)

Added by Martin Helmich about 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-09-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The class TYPO3\CMS\Core\Package\PackageManager overwrites the method injectClassLoader from it's parent class with a different signature (the type hint is TYPO3\CMS\Core\Core\ClassLoader instead of TYPO3\Flow\Core\ClassLoader). This violates the Liskov Substitution Principle and triggers warnings when PHP's error level includes the E_STRICT bit (this single issue fills our error logs with ~140 million lines per day).

Proposed fix on Gerrit will follow shortly.

#1

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42983

#2

Updated by Markus Sommer about 5 years ago

  • Assignee set to Martin Helmich
#3

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42983

#4

Updated by Helmut Hummel about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF