Project

General

Profile

Actions
Copy link

Bug #69476

closed

Declaration of TYPO3\CMS\Core\Package\PackageManager::injectClassLoader() should be compatible with TYPO3\Flow\Package\PackageManager::injectClassLoader(TYPO3\Flow\Core\ClassLoader $classLoader)

Added by Martin Helmich about 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Martin Helmich
Category:
-
Target version:
-
Start date:
2015-09-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The class TYPO3\CMS\Core\Package\PackageManager overwrites the method injectClassLoader from it's parent class with a different signature (the type hint is TYPO3\CMS\Core\Core\ClassLoader instead of TYPO3\Flow\Core\ClassLoader). This violates the Liskov Substitution Principle and triggers warnings when PHP's error level includes the E_STRICT bit (this single issue fills our error logs with ~140 million lines per day).

Proposed fix on Gerrit will follow shortly.

Actions
Copy link

Also available in: Atom PDF