Bug #69476
closed
Declaration of TYPO3\CMS\Core\Package\PackageManager::injectClassLoader() should be compatible with TYPO3\Flow\Package\PackageManager::injectClassLoader(TYPO3\Flow\Core\ClassLoader $classLoader)
100%
Description
The class TYPO3\CMS\Core\Package\PackageManager overwrites the method injectClassLoader from it's parent class with a different signature (the type hint is TYPO3\CMS\Core\Core\ClassLoader instead of TYPO3\Flow\Core\ClassLoader). This violates the Liskov Substitution Principle and triggers warnings when PHP's error level includes the E_STRICT bit (this single issue fills our error logs with ~140 million lines per day).
Proposed fix on Gerrit will follow shortly.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42983
Updated by
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42983
Updated by Helmut Hummel over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6db8afe60a9e0bd13388497603596571da8c5486.
Updated by