Project

General

Profile

Actions

Bug #69642

closed

Crash on Workspace Preview if page in menu is hidden on LiveWS

Added by Alexander Opitz over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2015-09-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

After the changes in #33436 we crash, if you preview a page with menu which have a page which is hidden on LiveWS.

See my comment in the change for the position: https://review.typo3.org/#/c/42553/3/typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php

Actions #1

Updated by Daniel Goerz over 8 years ago

  • Status changed from New to Closed

HI Alex, I close this as duplicate of #67001. I copied your comment to that ticket to keep all information together.

Actions #2

Updated by Alexander Opitz over 8 years ago

  • Status changed from Closed to New

Reopen:

The issue, which I mention exists since 6.2.15 and is inside the menu.
This doesn't have to do with the issue #67001, which is about viewing the page which is hidden in Live (which doesn't crash TYPO3 this only do not work).

Actions #3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43188

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43188

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43189

Actions #6

Updated by Alexander Opitz over 8 years ago

Testing:

- You need a menu configured with the special "directory"
- On Live set a page in the menu directory to hidden
- Open the page as Workspace preview
- You will get SQL statements like "SELECT FROM 'pages'" (See the missing field names in the select). This comes from the versionOL with an empty row.

Actions #7

Updated by Alexander Opitz over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Alexander Opitz over 8 years ago

  • Status changed from Resolved to Under Review

Fix for master is still open.

Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43189

Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43189

Actions #11

Updated by Alexander Opitz over 8 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44639

Actions #13

Updated by Markus Sommer over 8 years ago

  • Assignee set to Oliver Hader
Actions #14

Updated by Alexander Opitz over 8 years ago

  • Status changed from Under Review to Closed

Reclose as Review https://review.typo3.org/44639 wasn't for this issue.

Actions

Also available in: Atom PDF