Task #69730
closedStory #69712: Further FormEngine development
Remove dot in uniqid('NEW', TRUE)
100%
Description
DatabaseUniqueUidNewRow creates a "dummy" uid for new records. This is given to the DataHandler later, it then persists the new row and substitutes this placeholder with the real uid somehow.
Problem is, that the call uniqid('NEW', TRUE) creates a string like "NEW12345678.1234567". Mind the dot. This is triggered by the second argument as TRUE and makes sure that if uniqid() is called multiple times on windows, still a different result is returned. So, TRUE must be kept.
But: The dot is not a valid character in html attributes like id. so id="NEW123.456" is invalid and gives headaches. Thus, there are some places hidden somewhere in element and container classes within FormEngine, that remove this dot again, if this one is used as id or at other places in DOM.
Task is: Do the removal of the dot in DatabaseUniqueUidNewRow once and for all, locate all within FormEngine that currently does that manually and remove these hacks.
Updated by Stephan Großberndt over 9 years ago
there are several other places in core where uniqid() is called. this should be unified in general to produce generic unique ids usable as well for html as js as mysql identifiers
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43244
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43244
Updated by Nicole Cordes over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6465f2f051f7d7d9a2418e080e19ab16fd5196ba.
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Updated by Stephan Großberndt over 4 years ago
- Related to Bug #91553: Risk of non-unique field in DatePickerViewHelper added