Project

General

Profile

Actions
Copy link

Bug #69807

closed

EXT:form - currency filter not working correctly

Added by Björn Jacob over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
7 LTS
Start date:
2015-09-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

The currency filter is not working as expected. To reproduce the issue do the following:

  1. have a form with a confirmation page or a field which is required (to make sure form is not submitted but validated)
  2. enter 34567890 into a TEXTLINE or TEXTAREA element
  3. submit form
  4. new value is as expected 34.567.890,00
  5. submit form
  6. new value is 34,57
  7. submit form
  8. new value is 34,00

The filter is configured as follows:


temp.filterCurrency = currency
temp.filterCurrency {
    # default: .
    decimalPoint = ,
    # default: ,
    thousandSeparator = .
}

If the default configuration of this filter is used the second step (34,57) is not happening :) but the final result is 34.00.

Actions
Copy link
 #1

Updated by Björn Jacob over 8 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Björn Jacob over 8 years ago

  • Subject changed from Forms: currency filter not working correctly to EXT:form - currency filter not working correctly
Actions
Copy link
 #3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43475

Actions
Copy link
 #4

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43476

Actions
Copy link
 #5

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43476

Actions
Copy link
 #6

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43491

Actions
Copy link
 #7

Updated by Ralf Zimmermann over 8 years ago

Note, there are 2 Reviews:

TYPO3 6.2: https://review.typo3.org/#/c/43491/
TYPO3 7: https://review.typo3.org/#/c/43475/

Actions
Copy link
 #8

Updated by Björn Jacob over 8 years ago

  • Target version set to 7.5
Actions
Copy link
 #9

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43475

Actions
Copy link
 #10

Updated by Benni Mack over 8 years ago

  • Sprint Focus set to Stabilization Sprint
Actions
Copy link
 #11

Updated by Björn Jacob over 8 years ago

  • Target version changed from 7.5 to 7 LTS
Actions
Copy link
 #12

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43475

Actions
Copy link
 #13

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43475

Actions
Copy link
 #14

Updated by Björn Jacob over 8 years ago

Example form for faster testing:


enctype = multipart/form-data
method = post
prefix = tx_form
confirmation = 1
postProcessor {
    1 = mail
    1 {
        recipientEmail = your@mail.com
        senderEmail = your@mail.com
        subject = Test form
    }
}
10 = TEXTLINE
10 {
    type = text
    class = hasClass1
    id = hasId1
    autocomplete = off
    name = salary
    placeholder = Enter your desired salary.
    filters {
        1 = currency
        1 {
            decimalPoint = .
            thousandSeparator = ,
        }
    }
    label {
        value = Salary
    }
}
20 = SUBMIT
20 {
    name = 3
    type = submit
    value = Submit form
}
rules {
    1 = required
    1 {
        breakOnError = 0
        showMessage = 1
        message = Required
        error = This field is required
        element = salary
    }
}
Actions
Copy link
 #15

Updated by Ralf Zimmermann over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #16

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43491

Actions
Copy link
 #17

Updated by Ralf Zimmermann over 8 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #18

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF