Task #69827

Use JsConfirmation enumeration for BackendUserAuthentication check

Added by Mathias Brodala about 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
-
Start date:
2015-09-15
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The method BackendUserAuthentication::jsConfirmation doesn't check if passed/configured values are valid for the JsConfirmation enumeration but it should.


Related issues

Related to TYPO3 Core - Bug #78240: user tsconfig setting alertPopups has no effect Closed 2016-10-11
Related to TYPO3 Core - Bug #76719: UserTs alertPopups still shown Closed 2016-06-21

Associated revisions

Revision 8a79bfa5 (diff)
Added by Andreas Wolf over 3 years ago

[TASK] Use JsConfirmation enumeration in BackendUserAuthentication

This makes use of the JsConfirmation enumeration to ensure valid values
in BackendUserAuthentication::jsConfirmation.

As combinations of values are allowed, we need to check for all possible
combinations by comparing to an OR-ed bitmask with all possible bits.
Additionally, this fixes a bug where setting the TSconfig option to "0"
would yield a value of 255, which would enable all notifications instead
of disabling them.

Resolves: #69827
Releases: master
Change-Id: I59b8b8de3efb5c33273ea4c7dfdad2ac25473463
Reviewed-on: https://review.typo3.org/43330
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43330

#2 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43330

#3 Updated by Anja Leichsenring about 4 years ago

  • Sprint Focus changed from On Location Sprint to Stabilization Sprint

#4 Updated by Benni Mack about 4 years ago

  • Target version deleted (7.5)
  • Sprint Focus deleted (Stabilization Sprint)

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43330

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43330

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43330

#8 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43330

#9 Updated by Andreas Wolf over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF