Project

General

Profile

Actions

Bug #70243

closed

Polishing dropdown selectors for 7.6 LTS

Added by Rafal Brzeski over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Start date:
2015-10-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In TYPO3 7 bootstraped dropdown selectors dont fits to the rest of form fields, there is a different border-radius, disabled border-top-left and bottom radius didn't work with add ons, furthermore dropdowns looks different in every browser.
There is a pretty simple workaround for this case, I think TYPO3 7.6 LTS needs improvements in this place because this is a matter of image.

This is what should be done:

select.form-control {
  background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg%20version%3D%221.1%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20xmlns%3Axlink%3D%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%22%20width%3D%2224%22%20height%3D%2224%22%20viewBox%3D%220%200%2024%2024%22%3E%0A%3Cpath%20fill%3D%22#000%22%20d%3D%22M7%2010l5%205%205-5z%22%3E%3C%2Fpath%3E%0A%3C%2Fsvg%3E");
  padding-right: 25px;
  background-repeat: no-repeat;
  background-position: right center;

  &:-ms-expand {
    display: none;
  }
}

You can look at the live example http://r4fx.github.io/mate/doc/www/forms.html#nav-basic
Please make the selectors look beautiful! :-)


Files

ugly dropdown with addon.png (22.2 KB) ugly dropdown with addon.png Rafal Brzeski, 2015-10-01 01:42
pretty dropdown with addon.png (27.9 KB) pretty dropdown with addon.png Rafal Brzeski, 2015-10-01 01:42
Cattura-7.6-firefox.PNG (5.72 KB) Cattura-7.6-firefox.PNG latest Firefox, Windows 7 Riccardo De Contardi, 2015-10-15 17:27
Cattura-7.6-IE10.PNG (8.27 KB) Cattura-7.6-IE10.PNG Internet Explorer 10, Windows 7 Riccardo De Contardi, 2015-10-15 17:27
Cattura-7.6-chrome.PNG (10 KB) Cattura-7.6-chrome.PNG latest Chrome, Windows 7 Riccardo De Contardi, 2015-10-15 17:29
unfold-more.svg (351 Bytes) unfold-more.svg Rafal Brzeski, 2015-10-15 22:25

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #71395: Apply custom styling on <select> tagsClosedAndreas Kienast2015-11-07

Actions

Updated by Riccardo De Contardi over 8 years ago

Hi Rafal,
as far as I can see, this has been solved on the latest master (7.6-dev). Can you confirm? I attach some screenshots.

Actions #2

Updated by Riccardo De Contardi over 8 years ago

  • File deleted (Cattura-7.6-chrome.PNG)
Actions #4

Updated by Rafal Brzeski over 8 years ago

I checked it, and... no. I noticed out that it looks nice on Windows, not on Mac, so my screenshots are still valid but for Apple devices.

Actions #5

Updated by Riccardo De Contardi over 8 years ago

  • Status changed from Needs Feedback to New
Actions #6

Updated by Riccardo De Contardi over 8 years ago

I would suggest something like:

select.form-control{
    -webkit-appearance: none;
    -webkit-border-radius: 0px;
}

Actions #7

Updated by Rafal Brzeski over 8 years ago

this is not a good idea, when you put -webkit-appearance: none; arrow from the right will disappear.

I prepared jsfiddle with complex code example - https://jsfiddle.net/x76j455z/8/ tested on many browsers and systems on Browserstack, and it looks nice everywhere.

Whole idea is simple, just disable predefined appearance on every browser, and then we can do anything with dropdown, to achieve arrow sign from the right we can use svg icon compressed with base64 as background image.
This method is from css tricks https://css-tricks.com/probably-dont-base64-svg/, svg icon may be compressed by online tools like http://pressbin.com/tools/urlencode_urldecode/.

I looked a long time for the best results to style native dropdown selector which will look the same in all browsers, and this is one of the best method I found.

Actions #8

Updated by Riccardo De Contardi over 8 years ago

you are right, I did not notice it :) we could add the background base64-encoded svg as you suggest :)

Actions #9

Updated by Riccardo De Contardi over 8 years ago

  • Category set to Backend User Interface
Actions #10

Updated by Mathias Schreiber over 8 years ago

  • Target version set to Candidate for patchlevel
Actions #11

Updated by Gianluigi Martino over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Gianluigi Martino
Actions #12

Updated by Gerrit Code Review over 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45443

Actions #13

Updated by Andreas Kienast over 8 years ago

Is this ticket still up-to-date? A patch of mine was merged at 8. of November that actually solves the issue: https://review.typo3.org/#/c/44367/

Actions #14

Updated by Rafal Brzeski over 8 years ago

this issue was solved and may be closed

Actions #15

Updated by Gianluigi Martino over 8 years ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF