Bug #70278

Epic #69955: Optimize new Extbase/ Fluid based rewrite of EXT:form

EXT:form - wrong Radio / Checkbox handling if no value is set

Added by Ralf Zimmermann about 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2015-10-01
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

  1. Submit the form below.
  2. Now all options are shown at the confirmation page.
  3. Go back to the form.
  4. All options and checkboxes are selected.
  5. This happens if there are no "value" properties are set.

handleIncomingFormValues compares the incoming data with the data from the configuration.
In this case both values are NULL and the comparison is TRUE.
Now the element is marked as selected.

prefix = tx_form
confirmation = 1

postProcessor {
    1 = mail
    1 {
        recipientEmail = your@mail.com
        senderEmail = your@mail.com
    }
}

10 = CHECKBOXGROUP
10 {
    class = fieldset-subgroup
    legend {
        value = Edit this legend
    }
    name = checkboxgroup

    10 = CHECKBOX
    10 {
        label {
            value = Option 1
        }
    }

    20 = CHECKBOX
    20 {
        label {
            value = Option 2
        }
    }

    30 = CHECKBOX
    30 {
        label {
            value = Option 3
        }
    }
}

20 = RADIOGROUP
20 {
    class = fieldset-subgroup
    legend {
        value = Edit this legend
    }
    name = radiogroup

    10 = RADIO
    10 {
        label {
            value = Option 1
        }
    }

    20 = RADIO
    20 {
        label {
            value = Option 2
        }
    }
    30 = RADIO
    30 {
        label {
            value = Option 3
        }
    }
}

30 = CHECKBOX
30 {
    name = checkbox1
    label {
        value = Option 4
    }
}

40 = RADIO
40 {
    name = option1
    label {
        value = Option 5
    }
}

50 = SUBMIT
50 {
    name = 6
    value = Submit form
}

Associated revisions

Revision 4fc92699 (diff)
Added by Ralf Zimmermann about 4 years ago

[BUGFIX] EXT:form - Wrong radio/ checkbox handling if no value is set

Do not mark a radio or checkbox as selected, if no "value" property
is set within the configuration and no incoming data exists.

Resolves: #70278
Releases: master
Change-Id: I5d9b1344d1581fb42b9d39bf0834a62fe56d252d
Reviewed-on: http://review.typo3.org/43707
Reviewed-by: Bjoern Jacob <>
Tested-by: Bjoern Jacob <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

History

#1 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43707

#2 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43707

#3 Updated by Bjoern Jacob about 4 years ago

  • Description updated (diff)

#4 Updated by Ralf Zimmermann about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF