Project

General

Profile

Actions

Bug #70455

closed

EXT:form - Wrong attribute handling for some attributes in form wizard

Added by Björn Jacob over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2015-10-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There are some attributes which are not properly written by the form wizard. For example setting the autofocus attribute the wizard sets autofocus="1". This is not correct. At least it should set autofocus="autofocus". Unfortunatelly, it's not possible to just set autofocus. This would be proper HTML5 syntax but it is not supported by the FE rendering.

Actions #1

Updated by Ralf Zimmermann over 8 years ago

form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.js
Lin 171
inputValue: 'checked'

This value is set for some of the attributes but never used.
I would be nice if this value is written instead of "1".

Actions #2

Updated by Ralf Zimmermann over 8 years ago

affected attributes:

autofocus
checked
disabled
hidden
multiple
novalidate
readonly
required
selected

Actions #3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions #8

Updated by Björn Jacob over 8 years ago

  • Assignee deleted (Sebastian Wagner)

Steps to reproduce:

  1. add this PageTs to your page:

mod.wizards.form.elements {
    textline.accordions.attributes.showProperties := addToList(autofocus, disabled, hidden, readonly, required)
    checkbox.accordions.attributes.showProperties := addToList(checked)
    form.accordions.attributes.showProperties := addToList(novalidate)
}

  1. create new form
  2. open wizard
  3. create new TEXTLINE element
    1. open tab "Attributes properties"
    2. check the following options: Autofocus, Disabled, Hidden, Readonly, Required
  4. create new CHECKBOX element
    1. open tab "Attributes properties"
    2. check the following options: Checked
  5. create new SELECT element
    1. open tab "Attributes properties"
    2. check the following options: Multiple
  6. open main tab "Form"
    1. open tab "Attributes properties"
    2. check the following options "Novalidate"
Actions #9

Updated by Sebastian Wagner over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF