Bug #70455: EXT:form - Wrong attribute handling for some attributes in form wizard - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #70455

closed

EXT:form - Wrong attribute handling for some attributes in form wizard

Added by Björn Jacob about 9 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Form Framework

Target version:

7 LTS

Start date:

2015-10-07

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

There are some attributes which are not properly written by the form wizard. For example setting the autofocus attribute the wizard sets autofocus="1". This is not correct. At least it should set autofocus="autofocus". Unfortunatelly, it's not possible to just set autofocus. This would be proper HTML5 syntax but it is not supported by the FE rendering.

Actions

Copy link

Updated by Ralf Zimmermann about 9 years ago

form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.js

Lin 171

inputValue: 'checked'

This value is set for some of the attributes but never used.
I would be nice if this value is written instead of "1".

Actions

Copy link

Updated by Ralf Zimmermann about 9 years ago

affected attributes:

autofocus
checked
disabled
hidden
multiple
novalidate
readonly
required
selected

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884

Actions

Copy link

Updated by Björn Jacob about 9 years ago

Assignee deleted (~~Sebastian Wagner~~)

Steps to reproduce:

add this PageTs to your page:


mod.wizards.form.elements {
    textline.accordions.attributes.showProperties := addToList(autofocus, disabled, hidden, readonly, required)
    checkbox.accordions.attributes.showProperties := addToList(checked)
    form.accordions.attributes.showProperties := addToList(novalidate)
}

create new form
open wizard
create new TEXTLINE element
1. open tab "Attributes properties"
2. check the following options: Autofocus, Disabled, Hidden, Readonly, Required
create new CHECKBOX element
1. open tab "Attributes properties"
2. check the following options: Checked
create new SELECT element
1. open tab "Attributes properties"
2. check the following options: Multiple
open main tab "Form"
1. open tab "Attributes properties"
2. check the following options "Novalidate"