Bug #70455
closedEXT:form - Wrong attribute handling for some attributes in form wizard
100%
Description
There are some attributes which are not properly written by the form wizard. For example setting the autofocus attribute the wizard sets autofocus="1"
. This is not correct. At least it should set autofocus="autofocus"
. Unfortunatelly, it's not possible to just set autofocus
. This would be proper HTML5 syntax but it is not supported by the FE rendering.
Updated by Ralf Zimmermann almost 9 years ago
form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.jsLin 171
inputValue: 'checked'
This value is set for some of the attributes but never used.
I would be nice if this value is written instead of "1".
Updated by Ralf Zimmermann almost 9 years ago
affected attributes:
autofocus
checked
disabled
hidden
multiple
novalidate
readonly
required
selected
Updated by Gerrit Code Review almost 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884
Updated by Gerrit Code Review almost 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43884
Updated by Björn Jacob almost 9 years ago
- Assignee deleted (
Sebastian Wagner)
Steps to reproduce:
- add this PageTs to your page:
mod.wizards.form.elements { textline.accordions.attributes.showProperties := addToList(autofocus, disabled, hidden, readonly, required) checkbox.accordions.attributes.showProperties := addToList(checked) form.accordions.attributes.showProperties := addToList(novalidate) }
- create new form
- open wizard
- create new TEXTLINE element
- open tab "Attributes properties"
- check the following options: Autofocus, Disabled, Hidden, Readonly, Required
- create new CHECKBOX element
- open tab "Attributes properties"
- check the following options: Checked
- create new SELECT element
- open tab "Attributes properties"
- check the following options: Multiple
- open main tab "Form"
- open tab "Attributes properties"
- check the following options "Novalidate"
Updated by Sebastian Wagner almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c49b5b293e62641cb557e33fe43632855e2ffeeb.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed