Bug #70494

Story #69617: FormEngine bugs

AbstractFormElement opening IRRE via ajax fails if it contains thumbnails because $GLOBALS['SOBE'] is not set

Added by Andreas Allacher about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2015-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Testing this with 7.5, so it might already work correctly for master but if I have a record with inline elements that contains records via group element then when wrapClickMenuOnIcon is called it will fail because $GLOBALS['SOBE'] is not set.


Related issues

Related to TYPO3 Core - Bug #65728: Call to a member function wrapClickMenuOnIcon() on a non-objectClosed2015-03-14

Actions
#1

Updated by Christian Kuhn about 5 years ago

  • Parent task set to #69617

wah, args ... could you trace where exactly the sobe call happens and give us the backtrace?

#2

Updated by Andreas Allacher about 5 years ago

For full backtrac you have to wait until tomorrow but it is called here:
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php#l700

Which is e.g. called here:
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Form/Element/GroupElement.php

So if there is an element which calls that method in the IRRE record this fails :)

#3

Updated by Andreas Bouche about 5 years ago

Can confirm that for current master. Happens when I'm in Quick Edit mode on a page containing the felogin plugin.
Backtrace:

( ! ) Fatal error: Call to a member function wrapClickMenuOnIcon() on a non-object in /var/www/typo3git/typo3_src/typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php on line 697
Call Stack
  1. Time Memory Function Location
    1 0.0038 242240 {main}( ) .../index.php:0
    2 0.8973 243936 call_user_func:{/var/www/typo3git/typo3_src/typo3/index.php:21} ( ? ) .../index.php:21
    3 0.8974 243976 {closure:/var/www/typo3git/typo3_src/typo3/index.php:18-21}( ) .../index.php:21
    4 0.9185 3733632 TYPO3\CMS\Backend\Http\Application->run( ?
    ) .../index.php:20
    5 0.9185 3733744 TYPO3\CMS\Core\Core\Bootstrap->handleRequest( ? ) .../Application.php:94
    6 0.9189 3755072 TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->handleRequest( ?
    ) .../Bootstrap.php:302
    7 0.9791 8454992 TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule( ? ) .../BackendModuleRequestHandler.php:92
    8 0.9809 8502208 TYPO3\CMS\Core\Http\Dispatcher->dispatch( ?
    , ? ) .../BackendModuleRequestHandler.php:195
    9 0.9813 8529984 call_user_func_array:{/var/www/typo3git/typo3_src/typo3/sysext/core/Classes/Http/Dispatcher.php:41} ( ?
    , ? ) .../Dispatcher.php:41
    10 0.9813 8530144 TYPO3\CMS\Backend\Controller\PageLayoutController->mainAction( ?
    , ? ) .../Dispatcher.php:41
    11 1.0695 9690216 TYPO3\CMS\Backend\Controller\PageLayoutController->main( ) .../PageLayoutController.php:559
    12 1.0903 10116144 TYPO3\CMS\Backend\Controller\PageLayoutController->renderQuickEdit( ) .../PageLayoutController.php:647
    13 1.2742 11499784 TYPO3\CMS\Backend\Form\Container\OuterWrapContainer->render( ) .../PageLayoutController.php:784
    14 1.2746 11515968 TYPO3\CMS\Backend\Form\Container\FullRecordContainer->render( ) .../OuterWrapContainer.php:54
    15 1.2751 11537872 TYPO3\CMS\Backend\Form\Container\TabsContainer->render( ) .../FullRecordContainer.php:84
    16 1.3753 11910904 TYPO3\CMS\Backend\Form\Container\PaletteAndSingleContainer->render( ) .../TabsContainer.php:90
    17 1.3754 11924032 TYPO3\CMS\Backend\Form\Container\SingleFieldContainer->render( ) .../PaletteAndSingleContainer.php:136
    18 1.3764 11944288 TYPO3\CMS\Backend\Form\Container\FlexFormEntryContainer->render( ) .../SingleFieldContainer.php:163
    19 1.3767 11961816 TYPO3\CMS\Backend\Form\Container\FlexFormTabsContainer->render( ) .../FlexFormEntryContainer.php:44
    20 1.3772 11986944 TYPO3\CMS\Backend\Form\Container\FlexFormElementContainer->render( ) .../FlexFormTabsContainer.php:84
    21 1.3792 12034120 TYPO3\CMS\Backend\Form\Element\GroupElement->render( ) .../FlexFormElementContainer.php:135
    22 1.3850 12281344 TYPO3\CMS\Backend\Form\Element\AbstractFormElement->dbFileIcons( ?
    , ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) .../GroupElement.php:310
#4

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44116

#5

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44116

#6

Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44116

#7

Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44116

#8

Updated by Andreas Bouche about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF