Project

General

Profile

Actions

Bug #71086

closed

Inheritance of backend layouts do not work correctly

Added by Wolfgang Wagner about 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2015-10-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
Stabilization Sprint

Description

The field "Backend Layout (subpages of this page)" affects also the current page, if the field "Backend Layout (this page only)" is not set. This behaviour is IMHO not correct and it was not the case in previous versions.

(noticed in the current TYPO3 Master)


Files

belayouts-inheritance-problem.png (49.9 KB) belayouts-inheritance-problem.png Wolfgang Wagner, 2015-10-28 09:24
Actions #1

Updated by Markus Klein about 9 years ago

  • Category set to Backend API
  • Target version set to 7 LTS
  • Is Regression changed from No to Yes
  • Sprint Focus set to Stabilization Sprint
Actions #2

Updated by Jo Hasenau about 9 years ago

I guess this is due to the usage of

foreach ($tsfe->rootLine as $rootLinePage)

in ContentObjectRenderer. Since the rootline includes the current page as well, we have to make sure to exclude that from the slide.

Actions #3

Updated by Markus Klein about 9 years ago

From
\TYPO3\CMS\Backend\View\BackendLayoutView::getSelectedCombinedIdentifier

                $rootLine = $this->getRootLine($pageId);
                // Remove first and last element (current and root page)
                array_shift($rootLine);
                array_pop($rootLine);
                foreach ($rootLine as $rootLinePage) {

So this is actually done there, but FE rendering is not consistent. typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:5951

Actions #4

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44365

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44365

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44365

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44365

Actions #8

Updated by Markus Klein about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF