Bug #71733

FSC SectionViewHelper does not fetch all CEs when column is not set

Added by Robert Heinig about 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Start date:
2015-11-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Reason: the value of the attribute "column" will be casted to int every time and the view helper will query CEs with colPos = 0.
Solution: do not force a "colPos"-condition wihin the query when no column attribute is set.


Related issues

Related to TYPO3 Core - Bug #73521: Section Menus are brokenClosedDaniel Goerz2016-02-17

Actions
#1

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#2

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#3

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#4

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#5

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46005

#6

Updated by Georg Ringer almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Hendrik Nadler almost 5 years ago

This leads to a regression:

$constraints[] = 'colPos IN(' . ($colPosList !== '' ?: '0') . ')';

Evaluates to "colPos IN (1)" if the ViewHelper is called without a "column" paramater.

(PHP 5.6)

#8

Updated by Wouter Wolters almost 5 years ago

This has been fixed already. See https://forge.typo3.org/issues/73521

#9

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF