Bug #71733

FSC SectionViewHelper does not fetch all CEs when column is not set

Added by Robert Heinig over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
-
Start date:
2015-11-20
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Reason: the value of the attribute "column" will be casted to int every time and the view helper will query CEs with colPos = 0.
Solution: do not force a "colPos"-condition wihin the query when no column attribute is set.


Related issues

Related to TYPO3 Core - Bug #73521: Section Menus are broken Resolved 2016-02-17

Associated revisions

Revision a55685ec (diff)
Added by Georg Ringer over 2 years ago

[BUGFIX] Improve colPos behaviour of SectionViewHelper

Make it possible to render a section menu of content elements
with ignoring the colPos field.

Additionally, a comma separated list of columns can be used
and not only a single colPos.

Resolves: #71733
Releases, master, 7.6
Change-Id: I5f1284ee860c926afd81141d8459efd71cff409d
Reviewed-on: https://review.typo3.org/45999
Reviewed-by: Markus Klein <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 37f9c614 (diff)
Added by Georg Ringer over 2 years ago

[BUGFIX] Improve colPos behaviour of SectionViewHelper

Make it possible to render a section menu of content elements
with ignoring the colPos field.

Additionally, a comma separated list of columns can be used
and not only a single colPos.

Resolves: #71733
Releases, master, 7.6
Change-Id: I5f1284ee860c926afd81141d8459efd71cff409d
Reviewed-on: https://review.typo3.org/46005
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision a846c92f (diff)
Added by Daniel Goerz over 2 years ago

[BUGFIX] Render correct colPos in section menus again

Resolves: #73521
Related: #71733
Releases: master, 7.6
Change-Id: Iddaea99304a3ab2ae69153a4da12c210adeda6f1
Reviewed-on: https://review.typo3.org/46745
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision ac243e7b (diff)
Added by Daniel Goerz over 2 years ago

[BUGFIX] Render correct colPos in section menus again

Resolves: #73521
Related: #71733
Releases: master, 7.6
Change-Id: Iddaea99304a3ab2ae69153a4da12c210adeda6f1
Reviewed-on: https://review.typo3.org/46746
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45999

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46005

#6 Updated by Georg Ringer over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Hendrik Nadler over 2 years ago

This leads to a regression:

$constraints[] = 'colPos IN(' . ($colPosList !== '' ?: '0') . ')';

Evaluates to "colPos IN (1)" if the ViewHelper is called without a "column" paramater.

(PHP 5.6)

#8 Updated by Wouter Wolters over 2 years ago

This has been fixed already. See https://forge.typo3.org/issues/73521

Also available in: Atom PDF