Project

General

Profile

Actions

Bug #72556

closed

Move placeholder won't be removed anymore in explicitADmode=>explicitAllow environments

Added by Uwe Trotzek over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Start date:
2016-01-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

When you have an instance with

'explicitADmode' => 'explicitAllow'

then the value in field list_type is important.

Because the Default Value of the column 'list_type' in the database differs from the default value defined in TCA, it will happen that the value for Move-Placeholders differs from the original ones.

When a non admin user tries to publish moved records, he cannot remove the Move-Placeholders because he has no permissions for list_type '0'.

How to reproduce:
- define 'explicitADmode' => 'explicitAllow'
- add non admin User as workspace owner
- go to draft mode
- create and publish a text element on a page
- move the element to another location
- publish the elemtent

The Move-Placeholder wont be removed and causes some follow up problems.

Quick Fix:
I don't know if changing the DB default value to '' has some side effects so I fixed it by adding:

'shadowColumnsForMovePlaceholders' => 'list_type',

to tt_content TCA.

Actions #1

Updated by Uwe Trotzek about 8 years ago

It should be:
'shadowColumnsForMovePlaceholders' => 'colPos, list_type',

otherwise MovePlaceholder won't get the correct colPos whichs results in a not visible element.

Before the change above the movePlaceholder got the configuration from "shadowColumnsForNewPlaceholders" as this is the fallback if no explicit "shadowColumnsForMovePlaceholders" configuration is found. So no problem with the colPos, but with list_type.

I hope a patch will be part of the next release.

Actions #2

Updated by Oliver Hader almost 8 years ago

Thx for your report. Since this is marked as regression, can you please provide the version when this seemed to be working prior to the problem occurred the first time?

Actions #3

Updated by Uwe Trotzek almost 8 years ago

The problem did not exist in Version 6.2.15. The problem occurred at least in 6.2.17.

Actions #4

Updated by Benni Mack almost 8 years ago

  • Target version changed from 6.2.18 to Candidate for patchlevel
Actions #5

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #6

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #7

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #8

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #9

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #10

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #11

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50947

Actions #12

Updated by Gerrit Code Review almost 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/50947

Actions #13

Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF