Bug #73657

Image wizard in the rtehtmlarea working again, but css-classes are not taken

Added by Harald no-lastname-given over 3 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
RTE (rtehtmlarea + ckeditor)
Start date:
2016-02-24
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

New version TYPO3: 7.6.4

The images Wizard has long does not work. I am pleased with many others, that this is so.
Unfortunately predefined css classes in BE or in FE are not accepted in the image wizard.
I refer to a current and correct RTE configuration which has long existed.

Thank you very much

Harald

I use: TYPO3 7.6.4 etc.

I refer to: https://forge.typo3.org/issues/71494

RTE.ts (16.7 KB) Harald no-lastname-given, 2016-02-24 20:43


Related issues

Related to TYPO3 Core - Bug #71494: image wizard in the rtehtmlarea Closed 2015-11-12

Associated revisions

Revision 5e7ba5c5 (diff)
Added by Markus Klein over 3 years ago

[BUGFIX] Set selected CSS class on image in RTE

Fix a copy&paste error in the javascript to set the selected class
on the image.

Resolves: #73657
Releases: master, 7.6
Change-Id: I8b7e3580185221f98d16c8fd48fe9f9fc21cfd52
Reviewed-on: https://review.typo3.org/46882
Reviewed-by: Harald <>
Tested-by: Harald <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 370f6ce4 (diff)
Added by Markus Klein over 3 years ago

[BUGFIX] Set selected CSS class on image in RTE

Fix a copy&paste error in the javascript to set the selected class
on the image.

Resolves: #73657
Releases: master, 7.6
Change-Id: I8b7e3580185221f98d16c8fd48fe9f9fc21cfd52
Reviewed-on: https://review.typo3.org/46892
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Mathias Schreiber over 3 years ago

  • Status changed from New to Needs Feedback
  • Assignee changed from Markus Klein to Mathias Schreiber

Hey Harald,

can you share the crucial parts of the RTE config so we can test it and make sure your config works?

#2 Updated by Harald no-lastname-given over 3 years ago

Certainly happy, but I am sending the complete RTE configuration - without the associated CSS file.

Thank you very much

The classes are e.g .: img-responsive rte-image, img-responsive rte-image-center ........

#3 Updated by Markus Klein over 3 years ago

Thanks Harald, looking into it. The responsible code is there, so I wonder why this is not applied.

#4 Updated by Markus Klein over 3 years ago

  • Status changed from Needs Feedback to Accepted
  • Assignee changed from Mathias Schreiber to Markus Klein
  • Priority changed from Should have to Must have
  • Target version set to Candidate for patchlevel
  • Complexity set to easy
  • Is Regression changed from No to Yes

Ok, the selector is correctly rendered, but the class is never applied to the image.
This is a JS bug.

#5 Updated by Harald no-lastname-given over 3 years ago

Hello Markus,

I am grateful for the rapid handling of this matter.

Friendly greeting

Harald

#6 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46882

#7 Updated by Markus Klein over 3 years ago

@Harald: Please test the fix and vote on Gerrit, thanks.

#8 Updated by Harald no-lastname-given over 3 years ago

Markus, the patch I applied and it works perfectly again!

I can only say SUPER

Have a nice evening

Harald

#9 Updated by Markus Klein over 3 years ago

@Harald: Welcome, but please VOTE on Gerrit: https://review.typo3.org/46882
Use your typo3.org account to login and click the reply button at the top. In the popup give +1 votes for Code-Review and Verified.

#10 Updated by Harald no-lastname-given over 3 years ago

I like to have done. I must confess that I did not know: - |

#11 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46892

#12 Updated by Markus Klein over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF