Project

General

Profile

Actions
Copy link

Task #75209

closed

Codecleanup for MenuViewHelperTrait

Added by Frank Nägler over 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Frank Nägler
Category:
Backend API
Target version:
8.2
Start date:
2016-03-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

The MenuViewHelperTrait contains a method which access $this->templateVariableContainer a property, which is not part of the Trait.
The property is part of the AbstractViewHelper. This is a bad cody style and should be changed.

In general all methods of the Trait could be implemented in a AbstractMenuViewHelper class.

I would prefer to remove the Trait and move the logic into an Abstract class.

Actions
Copy link
 #1

Updated by Frank Nägler over 8 years ago

  • Status changed from New to Accepted
  • Assignee set to Frank Nägler
  • Target version changed from 8.0 to 8.1
Actions
Copy link
 #2

Updated by Benni Mack over 8 years ago

  • Target version changed from 8.1 to 8.2
Actions
Copy link
 #3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #7

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #8

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111

Actions
Copy link
 #9

Updated by Frank Nägler over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF