Task #75209
closedCodecleanup for MenuViewHelperTrait
100%
Description
The MenuViewHelperTrait
contains a method which access $this->templateVariableContainer
a property, which is not part of the Trait.
The property is part of the AbstractViewHelper
. This is a bad cody style and should be changed.
In general all methods of the Trait could be implemented in a AbstractMenuViewHelper
class.
I would prefer to remove the Trait and move the logic into an Abstract class.
Updated by Frank Nägler over 8 years ago
- Status changed from New to Accepted
- Assignee set to Frank Nägler
- Target version changed from 8.0 to 8.1
Updated by Gerrit Code Review over 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Gerrit Code Review about 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Gerrit Code Review about 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Gerrit Code Review about 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Gerrit Code Review about 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48111
Updated by Frank Nägler about 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c395609192468de8e1f60e1bfd81f1a0b174b4be.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed