Task #76044

Adequate table field declarations in fe_users table

Added by Thomas Löffler over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2016-05-07
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hi,

I realized some problems with the length of some fe_users table fields:

  1. There are three fields for name parts (first_name, middle_name, last_name), which have varchar(50). But the field "name" (which would be used to concatenate the other three fields) has varchar(80). Imho this should be increased to varchar(153) minimum (50*3 + 3 spaces).
  2. The fields "phone" and "fax" have varchar(20), which should be increased as well. If you take the international styled phone number from WMDB for example (+49 (0)211 416 889 20), you have 21 chars. And german numbers can be minimum 1 char longer.

Due to the MySQL documentation the varchar field is variable-based and will take that space the content needs, so it should be no problem to increase them:

Values in VARCHAR columns are variable-length strings. The length can be specified as a value from 0 to 65,535. The effective maximum length of a VARCHAR is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used.


Subtasks

Bug #76075: TCA field lengths and SQL data definition should matchClosedLudwig Rafelsberger2016-05-07

Actions
#1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48013

#2

Updated by Nicole Cordes over 5 years ago

Thomas Löffler wrote:

Imho this should be increased to varchar(153) minimum (50*3 + 3 spaces).

You only need 2 spaces to concat three items :-P

#3

Updated by Daniel Goerz over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Riccardo De Contardi about 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF