Task #76044
closedAdequate table field declarations in fe_users table
100%
Description
Hi,
I realized some problems with the length of some fe_users table fields:
- There are three fields for name parts (first_name, middle_name, last_name), which have varchar(50). But the field "name" (which would be used to concatenate the other three fields) has varchar(80). Imho this should be increased to varchar(153) minimum (50*3 + 3 spaces).
- The fields "phone" and "fax" have varchar(20), which should be increased as well. If you take the international styled phone number from WMDB for example (+49 (0)211 416 889 20), you have 21 chars. And german numbers can be minimum 1 char longer.
Due to the MySQL documentation the varchar field is variable-based and will take that space the content needs, so it should be no problem to increase them:
Values in VARCHAR columns are variable-length strings. The length can be specified as a value from 0 to 65,535. The effective maximum length of a VARCHAR is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48013
Updated by Nicole Cordes over 8 years ago
Thomas Löffler wrote:
Imho this should be increased to varchar(153) minimum (50*3 + 3 spaces).
You only need 2 spaces to concat three items :-P
Updated by Daniel Goerz over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ee448440bc74608e1e54198b7c2defe6bfed761d.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed