Project

General

Profile

Actions

Task #76915

closed

Epic #73121: Render() method arguments should be moved to initializeArguments()

Move method arguments to initializeArguments() in ext:indexed_search and ext:filelist

Added by Wouter Wolters over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2016-07-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Move method arguments to initializeArguments() in ext:indexed_search and ext:filelist

Actions #1

Updated by Wouter Wolters over 8 years ago

sysext/filelist/Classes/ViewHelpers/Be/ContainerViewHelper.php:63: public function render($pageTitle = '', $enableClickMenu = true, $loadExtJs = false, $loadExtJsTheme = true, $enableExtJsDebug = false, $loadJQuery = false, $includeCssFiles = null, $includeJsFiles = null, $addJsInlineLabels = null, $includeRequireJsModules = null, $addJsInlineLabelFiles = null, $addJsInline = null)
sysext/filelist/Classes/ViewHelpers/Be/ContainerViewHelper.php:71: $content = parent::render($pageTitle, $enableClickMenu, $loadExtJs, $loadExtJsTheme, $enableExtJsDebug, $loadJQuery, $includeCssFiles, $includeJsFiles, $addJsInlineLabels, $includeRequireJsModules);
sysext/filelist/Classes/ViewHelpers/Uri/EditSysFileMetadataRecordViewHelper.php:36: public function render($uid, $returnUrl = '')
sysext/filelist/Classes/ViewHelpers/Link/ClickMenuOnIconViewHelper.php:44: public function render($table)
sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php:54: public function render($maximumNumberOfResultPages, $numberOfResults, $resultsPerPage, $currentPage = 0, $freeIndexUid = null)
sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php:35: public function render($numberOfResults, $resultsPerPage, $currentPage = 1)
sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php:31: public function render($flags)

Actions #2

Updated by Wouter Wolters over 8 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49125

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49125

Actions #5

Updated by Riccardo De Contardi over 8 years ago

  • Category set to Code Cleanup
Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49125

Actions #7

Updated by Wouter Wolters over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF