Bug #77310

diff in workspaces lost colors

Added by Peter Niederlag about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Start date:
2016-07-29
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

As a sideeffect of git show aff26 / #69904 the record history in the workspace module lost the colors in the diff (see attached screenshots)

The styles, that add the colors on the <del> and <ins> elements, do not match the Html that is used inside the workspace.

workspace-colors-fixed-69904.png View (130 KB) Peter Niederlag, 2016-07-29 15:51

workspace-colors-lost-69904.png View (135 KB) Peter Niederlag, 2016-07-29 15:51

Associated revisions

Revision 48f38fe2 (diff)
Added by Peter Niederlag almost 2 years ago

[BUGFIX] Bring back some colors in workspace diff view

CSS definitions for <ins> and <del> tags. This is only needed for 7.6.
Followup to #69904 which didn't consider workspaces

Releases: 7.6
Resolves: #77310
Change-Id: Ibdb85fa82c3842dc237a5d3242913fbce81452df
Reviewed-on: https://review.typo3.org/49268
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Peter Niederlag about 2 years ago

  • File deleted (workspace-colors-fixed-69904.png)

#2 Updated by Peter Niederlag about 2 years ago

  • File deleted (workspace-colors-lost-69904.png)

#4 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49268

#5 Updated by Jan Helke almost 2 years ago

  • Sprint Focus set to On Location Sprint

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49268

#7 Updated by Peter Niederlag almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF