Task #69904

Use 3rd party diff utility

Added by Mathias Schreiber over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2015-09-16
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Remove the hiddeous code that used an exec call to diff while creating two files (I kid you not) before running the task.
We now use a sane PHP library to speed things up massively.

Sorry Seagate ;-)


Related issues

Related to TYPO3 Core - Task #69908: Adjust constract of new diff view Closed 2015-09-17
Related to TYPO3 Core - Bug #78767: Bad usability of workspace diff Closed 2016-11-22
Precedes TYPO3 Core - Bug #69923: Outdated composer.lock since #69904 Closed 2015-09-17

Associated revisions

Revision aff262b3 (diff)
Added by Mathias Schreiber over 3 years ago

[TASK] Replace DiffUtility with PHP library to save disk I/O

In order to make diff displays work cross platform and save A LOT of
disk I/O we replace the questionable approach with a slick PHP library

Resolves: #69904
Releases: master
Change-Id: Ifd76f32d2102f895d61de085142195dc1dbbc2ed
Reviewed-on: http://review.typo3.org/43382
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 470d85da (diff)
Added by Andreas Fernandez over 3 years ago

[TASK] Adjust contrast colors in diff view

Resolves: #69908
Related: #69904
Releases: master
Change-Id: Ibd4267c8b2255c55aed441482e2647209515464f
Reviewed-on: http://review.typo3.org/43386
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#8 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43382

#10 Updated by Mathias Schreiber over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Anja Leichsenring over 3 years ago

  • Sprint Focus deleted (On Location Sprint)

#12 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF