Task #77589

Allow EXT: syntax in PageRenderer and Compressor

Added by Benni Mack almost 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Miscellaneous
Target version:
Start date:
2016-08-22
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In order to minimize the relative path calculations, it should be possible to allow EXT: inside the page renderer and the resource compressor.


Related issues

Related to TYPO3 Core - Bug #83630: Config.absRefPrefix not working anymore for includeCSS, includeJs, includeJSLibs, includeCSSLibs after update to 8.7.9 Closed 2018-01-21

Associated revisions

Revision be5a95d2 (diff)
Added by Benni Mack almost 3 years ago

[FEATURE] Allow EXT: syntax in PageRenderer and Compressor

JS and CSS files can now be added via the EXT: syntax, to ease the
pain to a standardized way to include files with EXT: everywhere
now.

Resolves: #77589
Releases: master
Change-Id: Ie9de21cb5f9ea918f0ac069c83bc8020d11c299a
Reviewed-on: https://review.typo3.org/49491
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Philipp Gampe <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision c773dddf (diff)
Added by Andreas Fernandez almost 3 years ago

[FOLLOWUP][FEATURE] Allow EXT: syntax in PageRenderer and Compressor

The stylesheet files are included now by the PageRenderer to convert the
EXT: prefix into a real path, avoiding ERR_UNKNOWN_URL_SCHEME errors.

Resolves: #77589
Releases: master
Change-Id: I451604772f1e89957af73d68daf8a3d843b96731
Reviewed-on: https://review.typo3.org/49672
Reviewed-by: Wouter Wolters <>
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 0162ff19 (diff)
Added by Oliver Hader over 1 year ago

[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Resolves: #83630
Releases: master, 8.7
Change-Id: Ib01f698c14fb646173ec24e26027c7d657700f87
Reviewed-on: https://review.typo3.org/56108
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision 83f279ae (diff)
Added by Oliver Hader over 1 year ago

[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Resolves: #83630
Releases: master, 8.7
Change-Id: Ib01f698c14fb646173ec24e26027c7d657700f87
Reviewed-on: https://review.typo3.org/56126
Reviewed-by: Stefan Neufeind <>
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#2 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#5 Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#6 Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#7 Updated by Gerrit Code Review almost 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49491

#9 Updated by Benni Mack almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49672

#11 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49672

#12 Updated by Andreas Fernandez almost 3 years ago

  • Status changed from Under Review to Resolved

#13 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

#14 Updated by Oliver Hader over 1 year ago

  • Related to Bug #83630: Config.absRefPrefix not working anymore for includeCSS, includeJs, includeJSLibs, includeCSSLibs after update to 8.7.9 added

Also available in: Atom PDF