Project

General

Profile

Actions
Copy link

Bug #83630

closed

Config.absRefPrefix not working anymore for includeCSS, includeJs, includeJSLibs, includeCSSLibs after update to 8.7.9

Added by Frederick d. Maus about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
8.7.11
Start date:
2018-01-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Hello typo3 team

after a typo3 update from 8.7.8 to 8.7.9 i get the problem that the includeJSLibs, includeCSS, includeCSSLibs, ... Links are not anymore absolute in the frontend. Images files works. It means absRefPrefix not works anymore.

greets

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Task #77589: Allow EXT: syntax in PageRenderer and CompressorClosedBenni Mack2016-08-22

Actions
Has duplicate TYPO3 Core - Bug #82486: IncludeJS* / includeCSS* (including compression / concatenation) ignoring absRefPrefixClosed2017-09-14

Actions
Actions
Copy link
 #1

Updated by Riccardo De Contardi about 7 years ago

I performed the following test with 8.7.9 (fresh install):

config{
  no_cache = 1
  absRefPrefix = http://typo3.8.test/
}

page.includeCSS {
  file1 = fileadmin/teststylesheet.css
}

Results:

the stylesheet in <head> don't have the prepended absRefPrefix:

<link rel="stylesheet" type="text/css" href="/typo3temp/assets/css/d42b6e1bdf.css?1510479815" media="all">
<link rel="stylesheet" type="text/css" href="/fileadmin/teststylesheet.css?1516558177" media="all">

All other links (like header links of content elements, HMENU object, links inserted in RTE) instead have http://typo3.8.test/ prepended.

I don't have an 8.7.8 environment, but I performed the same test on 7.6.23 and it works as expected.

Actions
Copy link
 #2

Updated by Riccardo De Contardi about 7 years ago

  • Subject changed from typo3 update from 8.7.8 to 8.7.9 to Config.absRefPrefix not working anymore for includeCSS, includeJs, includeJSLibs, includeCSSLibs after update to 8.7.9
Actions
Copy link
 #3

Updated by Georg Ringer about 7 years ago

  • Is Regression set to Yes
Actions
Copy link
 #4

Updated by Georg Ringer about 7 years ago

i tested it even with 8.7.0 and is still prefixed with / only!

Actions
Copy link
 #5

Updated by Riccardo De Contardi about 7 years ago

Affects also 9.2.0-dev (latest master)

Actions
Copy link
 #6

Updated by Riccardo De Contardi about 7 years ago

  • Related to Bug #77722: absRefPrefix is not applied everywhere added
Actions
Copy link
 #7

Updated by Riccardo De Contardi about 7 years ago

  • Related to Bug #82486: IncludeJS* / includeCSS* (including compression / concatenation) ignoring absRefPrefix added
Actions
Copy link
 #8

Updated by Riccardo De Contardi about 7 years ago

There is a suggestion in #82486

Actions
Copy link
 #9

Updated by Oliver Hader about 7 years ago

  • Target version set to 8.7.11
Actions
Copy link
 #10

Updated by Georg Ringer about 7 years ago

IMO this doesnt even work with 7. can someone confirm?

Actions
Copy link
 #11

Updated by Oliver Hader about 7 years ago

Works in TYPO3 v7.6.25-dev, did not work in v8.7.0... so, that's not a recent "regression"...

Actions
Copy link
 #12

Updated by Oliver Hader about 7 years ago

  • Related to Task #77589: Allow EXT: syntax in PageRenderer and Compressor added
Actions
Copy link
 #13

Updated by Oliver Hader about 7 years ago

Introduced in #77589 which automatically prefixes with an absolute prefix / in PageRenderer::getStreamlinedFileName.
The according absRefPrefix handling in TypoScriptFrontendController::setAbsRefPrefix does not consider the leading slash whatsoever.

This behavior has been introduced in TYPO3 v8.4.0 already and thus is not a recent regression in the 8.7 LTS branch.

Actions
Copy link
 #14

Updated by Oliver Hader about 7 years ago

Two possible ways to solve this:
  • in TSFE extend the absRefPrefix search/replace logic by TYPO3_SITE_PATH prefix replacements (which does not cover if this has been used explicitly)
  • add special handling in PageRenderer whether to apply TYPO3_SITE_PATH at all (default might be true, disabled in PageGenerator - cave: PageRenderer is used for frontend and backend, TYPO3_SITE_PATH is perfectly fine and valid for backend usage)
Actions
Copy link
 #15

Updated by Markus Klein about 7 years ago

  • Has duplicate Bug #82486: IncludeJS* / includeCSS* (including compression / concatenation) ignoring absRefPrefix added
Actions
Copy link
 #16

Updated by Markus Klein about 7 years ago

  • Related to deleted (Bug #82486: IncludeJS* / includeCSS* (including compression / concatenation) ignoring absRefPrefix)
Actions
Copy link
 #17

Updated by Oliver Hader about 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #18

Updated by Oliver Hader about 7 years ago

  • Related to deleted (Bug #77722: absRefPrefix is not applied everywhere)
Actions
Copy link
 #19

Updated by Oliver Hader about 7 years ago

Removed reference to #77722 which is about extending the absRefPrefix functionality to any mention of those files - this is not related to this bug, but rather a new feature or behavior.

Actions
Copy link
 #20

Updated by Gerrit Code Review about 7 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #21

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #22

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #23

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #24

Updated by Gerrit Code Review about 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #25

Updated by Gerrit Code Review about 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #26

Updated by Gerrit Code Review about 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56108

Actions
Copy link
 #27

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56126

Actions
Copy link
 #28

Updated by Oliver Hader about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #29

Updated by Benni Mack over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF