Bug #77710

Configure the "rel" parameter for embedded Youtube videos

Added by Sebastian Michaelsen almost 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2016-08-31
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The YouTubeRenderer currently does not support the "rel" url parameter. Setting it to 0 it will prevent the display of related videos after finishing the embedded video.

https://developers.google.com/youtube/player_parameters#rel


Related issues

Related to TYPO3 Core - Task #78067: Adding functionality for Youtube "relative" Parameter Closed 2016-09-26
Related to TYPO3 Core - Feature #78078: Flexform: Support ds_pointerField pointing to a foreign record Closed 2016-09-27
Duplicated by TYPO3 Core - Task #78081: Adding functionality for Youtube "relative" Parameter Closed 2016-09-27
Duplicated by TYPO3 Core - Bug #78846: Allow parameters in Media assets or add checkbox for rel=0 in text&media Element Closed 2016-11-30

Associated revisions

Revision 779a6ff4 (diff)
Added by Tim Rücker almost 3 years ago

[BUGFIX] Add missing functionality for YouTube "related" parameter

This parameter indicates whether the player should show
related videos when playback of the initial video ends.
Supported values are 0 and 1. The default value is 1.

Releases: master,7.6
Resolves: #77710
Change-Id: I95576369b8dae579b39298095024bdbddc75ebc6
Reviewed-on: https://review.typo3.org/50031
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 37352982 (diff)
Added by Tim Rücker almost 3 years ago

[BUGFIX] Add missing functionality for YouTube "related" parameter

This parameter indicates whether the player should show
related videos when playback of the initial video ends.
Supported values are 0 and 1. The default value is 1.

Releases: master,7.6
Resolves: #77710
Change-Id: I95576369b8dae579b39298095024bdbddc75ebc6
Reviewed-on: https://review.typo3.org/50317
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Nicole Cordes almost 3 years ago

I would suggest to insert a hook into the class to be able to change the params before generating the src url.

#2 Updated by Sebastian Michaelsen almost 3 years ago

I'm currently working on a proof-of-concept extension that aims to bring flexform to sys_file_reference with options depending on the file type. I think the functionality would be well suited for the core, but I'd need/like some help with implementing it cleanly.

Here's a sneak preview:
http://giphy.com/gifs/l3vRewKXrUBvWr9Ic
http://giphy.com/gifs/l0MYAUGVRvl9nkqBO

#3 Updated by Riccardo De Contardi almost 3 years ago

related to #78067 there is a PR on github: https://github.com/TYPO3/TYPO3.CMS/pull/50

#4 Updated by Frans Saris almost 3 years ago

  • Tracker changed from Feature to Bug
  • TYPO3 Version set to 7
  • Is Regression set to No

@Sebastian I get the use-case and possible need of your flexform solution. But IMO thus is not something for the core but more for an extension.

When I developed the youtube / vimeo integration the main goal was to make it editor friendly. Imo that means give him as less as possible option to set ;). All the specific configuration is something for the integrator.
On the other hand the OnlineMedia API is flexible enough to add your wanted behaviour to the core in the form of an extension.

Basically extend the TCA of sys_file_reference to add the flexform + register your own YoutubeRenderer and VimeoRenderer. If you need some help with that just let me know (you can ping me on slack for instance).

Regarding the rel issue; the core renderer should be able to handle that attribute. Imo this is a bug that should be fixed. We should also check if we missed more attributes.

#5 Updated by Sebastian Michaelsen almost 3 years ago

https://github.com/smichaelsen/typo3-mediaoptions

The extension is in a proof-of-concept state. It has only been tested with fluid_styled_content so far and it contains some dirty workarounds.

#6 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#7 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#9 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#10 Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#11 Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#12 Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#13 Updated by Gerrit Code Review almost 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#14 Updated by Gerrit Code Review almost 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#15 Updated by Gerrit Code Review almost 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#16 Updated by Gerrit Code Review almost 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#17 Updated by Gerrit Code Review almost 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50031

#18 Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50317

#19 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50317

#20 Updated by Anonymous almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#21 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF