Bug #78574

ElementBrowser does not highlight selected file in filelist view

Added by Joerg Boesche almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
Joerg Boesche
Category:
Link Handling, Site Handling & Routing
Target version:
next-patchlevel
Start date:
2016-11-04
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

If an existing filereference is edited via the Link Wizard, the selected element is not highlighted in the element browser.

In Release 7.6.9 the element was highlighted. Since release 7.6.10 no longer. The reason is that the variable "$ linkParts [ 'url']" is of type string, not the integer type. A value and type comparison is made for the highlighting.

Affected file:
EXT: recordlist / Classes / LinkHandler / FileLinkHandler.php: 79
EXT: recordlist / Classes / LinkHandler / FileLinkHandler.php: 222

Solution:
EXT: recordlist / Classes / LinkHandler / FileLinkHandler.php: 79 must be cast as integer.

The trigger for the error is:
https://forge.typo3.org/issues/66369

Troubleshooting:
1. Login
2. Edit existing contentElement with link to fileElement
3. ElementBrowser (LinkWizard) will open
4. File is not highlighted (This is the bug)

Related issues

Related to TYPO3 Core - Task #66369: Introduce an API for adding tabs to the ElementBrowser Closed 2015-04-10

Associated revisions

Revision 21163a01 (diff)
Added by Joerg Boesche almost 2 years ago

[BUGFIX] ElementBrowser does not highlight selected file in file list view

FileLinkHandler in element browser should highlight the selected file
reference in browser. If the link value is "file:12345" the part after
"file:" from the string will be extracted and has to be cast as an int.
The later check for CSS class "active" in file list compares two numbers,
so the ID must be of type integer.

Resolves: #78574
Releases: 7.6
Change-Id: I11f8bf6bc73a08ff72edcb4769a206010d0226af
Reviewed-on: https://review.typo3.org/50502
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50501

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50502

#8 Updated by Joerg Boesche almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF