Task #66369

Story #46140: Add configurable linkhandler for arbitrary records

Introduce an API for adding tabs to the ElementBrowser

Added by Markus Klein almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2015-04-10
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
nightmare
Sprint Focus:
Stabilization Sprint

Description

Introduce a generic API to add tabs to the ElementBrowser and the RTE Link Wizard.

A tab registry should manage the available tabs.
Each tab has an associated TabHandler.
Multiple Tabs might have the same TabHandler.

A tab has:
  • an identifier
  • a title
  • a handler

Optional followup: Convert the existing tabs to the new API, which gives better separation of concerns.


Related issues

Related to TYPO3 Core - Bug #71232: Attributes are shared betweens tabs in Element Browser, titles are not Closed 2015-11-01
Related to TYPO3 Core - Bug #71233: Mail links need to prepend "mailto" Closed 2015-11-01
Related to TYPO3 Core - Bug #71252: Error when trying to use the link wizard in the rtehtmlarea Closed 2015-11-02
Related to TYPO3 Core - Bug #71298: Fix missing/broken RTE features after Link Handler API merge Accepted 2015-11-02
Related to TYPO3 Core - Bug #78574: ElementBrowser does not highlight selected file in filelist view Closed 2016-11-04
Precedes TYPO3 Core - Task #66372: Add a tab handler which can handle the selection of arbitrary records Closed 2015-04-11 2015-04-11
Precedes TYPO3 Core - Bug #12452: RTE LinkWizard is unstyled Closed 2015-04-11 2015-04-11

Associated revisions

Revision a91c3b33 (diff)
Added by Markus Klein over 3 years ago

[WIP][!!!][FEATURE] ElementBrowser refactoring, LinkBrowser API

This change refactors the ElementBrowser and splits it into
multiple dedicated classes for each mode.

  • Lots of unused code is removed.
  • All JS is moved into requireJS modules.
  • Tree classes are adjusted

The newly introduced LinkBrowser has few new APIs and hooks
to be flexbile and extensible.

Do not review yet!

Resolves: #
Related: #66369
Releases: master
Change-Id: I0a28663ce4c91c2405abc9e2a13063699c6bb231

Revision a5599ecf (diff)
Added by Markus Klein over 3 years ago

[WIP][!!!][FEATURE] ElementBrowser refactoring, LinkBrowser API

This change refactors the ElementBrowser and splits it into
multiple dedicated classes for each mode.

  • Lots of unused code is removed.
  • All JS is moved into requireJS modules.
  • Tree classes are adjusted

The newly introduced LinkBrowser has few new APIs and hooks
to be flexbile and extensible.

Do not review yet!

Resolves: #
Related: #66369
Releases: master
Change-Id: I0a28663ce4c91c2405abc9e2a13063699c6bb231

Revision 886626f3 (diff)
Added by Markus Klein over 3 years ago

[!!!][FEATURE] ElementBrowser refactoring, LinkBrowser API - Part 1

This change refactors the ElementBrowser and splits it into
multiple dedicated classes for each mode.

The former modes for file, folder and record selection are now
placed in dedicated *Browser classes.
The former mode "wizard", which defines its actual functionality
via the "act" variable, is a separate controller now, which
provides the API to be exensible.

The integration of the various trees and lists is solved by
a dedicated LinkParameterProviderInterface. Any class can
provides link parameters now by implementing this interface.

Other than that: * Lots of unused code is removed * All JS is moved into requireJS modules * Tree code is simplified by properly using constructors

Part 2 will: * add Breaking and Feature documentation * finalize RTE re-integration * finally delete unused classes

Resolves: #66369
Releases: master
Change-Id: I0a28663ce4c91c2405abc9e2a13063699c6bb231
Reviewed-on: http://review.typo3.org/42951
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 4eb0955d (diff)
Added by Markus Klein over 3 years ago

[!!!][FEATURE] ElementBrowser refactoring, LinkBrowser API - Part 2

Adjust link browser integration of RTE.

This removes the dedicated tree classes for RTE as those are useless
by now. Additionally the ElementBrowser class is finally removed.

Resolves: #66369
Releases: master
Change-Id: I8f42228cb3c4b3008d3f0acaa014d01733f6186d
Reviewed-on: https://review.typo3.org/43938
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

History

#1 Updated by Markus Klein almost 4 years ago

  • Parent task set to #46140

#2 Updated by Markus Klein almost 4 years ago

  • Subject changed from Introduce an API for adding Tabs to the ElementBrowser to Introduce an API for adding tabs to the ElementBrowser
  • Description updated (diff)
  • Status changed from In Progress to Accepted

#3 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#4 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#5 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#6 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#7 Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#8 Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#9 Updated by Benni Mack over 3 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)

#10 Updated by Markus Klein over 3 years ago

  • Category changed from Backend API to Link Handling, Site Handling & Routing

#11 Updated by Susanne Moog over 3 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#12 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38637

#13 Updated by Benni Mack over 3 years ago

  • Target version changed from 7.5 to 7 LTS

#14 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#15 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#16 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#17 Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#18 Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#19 Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#20 Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#21 Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#22 Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#23 Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#24 Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#25 Updated by Gerrit Code Review over 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42951

#26 Updated by Markus Klein over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#27 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43938

#28 Updated by Markus Klein over 3 years ago

  • % Done changed from 100 to 50
  • Complexity changed from medium to nightmare
  • Sprint Focus set to Stabilization Sprint

#29 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#30 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#31 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#32 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#33 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#34 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#35 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#36 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#37 Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#38 Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#39 Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#40 Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#41 Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#42 Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#43 Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#44 Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#45 Updated by Gerrit Code Review over 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43938

#46 Updated by Markus Klein over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100

#47 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF