Bug #79329: return_id param passed to permissions module is not evaluated - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #79329

closed

return_id param passed to permissions module is not evaluated

Added by Tymoteusz Motylewski almost 8 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Frank Nägler

Category:

Backend API

Target version:

Start date:

2017-01-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

During the permissions module refactoring http://review.typo3.org/33402 the code or the permissions module has hanged a lot.

In 2 places in the core (ClickMenu, DatabaseRecordList) the link to the permissions module contains `return_id` and `edit` parameters additionally to the `id` parameter.

However the permissions module is not evaluating `return_id` nor `edit` parameter.
It check for `returnId` (without underscore) param, however I'm not sure if it has the same meaning as the old `return_id`.
The question is, whether I can drop `return_id` usage,or should it be converted to `returnId` or sth else should happen?
Second question - is the "edit" parameter necessary, or should I drop it or adapt it to some new name?

Actions

Copy link

Updated by Frank Nägler almost 8 years ago

Category set to Backend API
Status changed from New to Accepted
Assignee set to Frank Nägler

Thanks for your report, after a quick check this must be changed:

1) the parameter return_id must be changed to returnId
2) the parameter edit must be changed to tx_beuser_system_beusertxpermission[action]=edit

I will provide a patch this evening.

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51330

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51330

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51401

Actions

Copy link