Project

General

Profile

Actions

Feature #79633

closed

Integrate next generation of Frontend Editing based on CKEditor

Added by Benni Mack over 7 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
Start date:
2017-02-10
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Add a new frontend editing extension that adds state-of-the-art inline editing for text elements.


Subtasks 1 (0 open1 closed)

Bug #79736: config.frontend_editing now known to t3editorClosed2017-02-10

Actions

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #66620: FE Edit viewhelperClosed2015-04-28

Actions
Actions #1

Updated by Benni Mack over 7 years ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #8

Updated by Gerrit Code Review over 7 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #9

Updated by Gerrit Code Review over 7 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #10

Updated by Gerrit Code Review over 7 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #11

Updated by Gerrit Code Review over 7 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #12

Updated by Gerrit Code Review over 7 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #13

Updated by Gerrit Code Review over 7 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #14

Updated by Gerrit Code Review over 7 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #15

Updated by Gerrit Code Review over 7 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #16

Updated by Gerrit Code Review over 7 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #17

Updated by Gerrit Code Review over 7 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #18

Updated by Gerrit Code Review over 7 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #19

Updated by Gerrit Code Review over 7 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #20

Updated by Gerrit Code Review over 7 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #21

Updated by Gerrit Code Review over 7 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #22

Updated by Gerrit Code Review over 7 years ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #23

Updated by Gerrit Code Review over 7 years ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #24

Updated by Gerrit Code Review over 7 years ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #25

Updated by Gerrit Code Review over 7 years ago

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #26

Updated by Gerrit Code Review over 7 years ago

Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #27

Updated by Gerrit Code Review over 7 years ago

Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #28

Updated by Gerrit Code Review over 7 years ago

Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #29

Updated by Gerrit Code Review over 7 years ago

Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #30

Updated by Gerrit Code Review over 7 years ago

Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #31

Updated by Gerrit Code Review over 7 years ago

Patch set 55 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #32

Updated by Gerrit Code Review over 7 years ago

Patch set 56 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #33

Updated by Gerrit Code Review over 7 years ago

Patch set 57 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #34

Updated by Mona Muzaffar over 7 years ago

Current issues i found

  • can’t edit header and bullet list elements
    - when you try to edit them, you get an orange border
    - no edit or whatsoever button, but it’s possible to write inline? Change just doesn’t get saved
  • when an element is positioned under one or more elements which can’t be edited and you move the element up with the arrow buttons,
    the uneditable elements get moved up as well
  • you can drag and drop some elements (only images?) and create some magic
    - wanted to position an image above a header. Outcome: Image is in header element (<h2><img></h2>)
    - when I drag and dropped a text and image element the image was duplicated
    - these changes don’t get saved, but you also can’t edit them in the frontend (orange border…)
  • JavaScript Error in Editor.js?bust=d17d8b7…:145 Uncaught TypeError: Cannot read property 'config' of null
  • ‚save all‘ and ‚discard‘ button don’t work
  • once you open the tool and properties bar it can partly overlay some content elements. You can’t edit those elements anymore, because the edit buttons
    are hidden behind the tool bar. (You wouldn’t be able to use fronted editing on a tablet)
  • the „Elements On Page“ dropdown in the tool bar can’t recognize titles of content elements, so every item is called ‚No Tiltle‘
  • When you want to create a new item and drag it into the page, you can’t drag them under uneditable items
  • When I create an invalid Form Element I can’t delete it in the frontend and can’t use the discard button, because the button doesn’t work.
Actions #35

Updated by Gerrit Code Review over 7 years ago

Patch set 58 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #36

Updated by Gerrit Code Review over 7 years ago

Patch set 59 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #37

Updated by Gerrit Code Review over 7 years ago

Patch set 60 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #38

Updated by Gerrit Code Review over 7 years ago

Patch set 61 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #39

Updated by Gerrit Code Review over 7 years ago

Patch set 62 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #40

Updated by Mattias Nilsson over 7 years ago

Mona Muzaffar wrote:

Current issues i found

  • can’t edit header and bullet list elements
    - when you try to edit them, you get an orange border
    - no edit or whatsoever button, but it’s possible to write inline? Change just doesn’t get saved
  • when an element is positioned under one or more elements which can’t be edited and you move the element up with the arrow buttons,
    the uneditable elements get moved up as well
  • you can drag and drop some elements (only images?) and create some magic
    - wanted to position an image above a header. Outcome: Image is in header element (<h2><img></h2>)
    - when I drag and dropped a text and image element the image was duplicated
    - these changes don’t get saved, but you also can’t edit them in the frontend (orange border…)
  • JavaScript Error in Editor.js?bust=d17d8b7…:145 Uncaught TypeError: Cannot read property 'config' of null
  • ‚save all‘ and ‚discard‘ button don’t work

They work when you have added the core:contentEditable viewhelper to an element, then the buttons gets trigger because content have been changed inline.

  • once you open the tool and properties bar it can partly overlay some content elements. You can’t edit those elements anymore, because the edit buttons
    are hidden behind the tool bar. (You wouldn’t be able to use fronted editing on a tablet)

The alignment have been changed of the icons, so that they now exists outside of the "Inline" part.

  • the „Elements On Page“ dropdown in the tool bar can’t recognize titles of content elements, so every item is called ‚No Tiltle‘

This is fixed.

  • When you want to create a new item and drag it into the page, you can’t drag them under uneditable items
  • When I create an invalid Form Element I can’t delete it in the frontend and can’t use the discard button, because the button doesn’t work.

This is now taken care of that, when an Extbase objects fails to render. An extended NotFoundView is triggered and wrapped with inline edit icons, so you can then remove the content element.

Actions #41

Updated by Gerrit Code Review over 7 years ago

Patch set 63 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #42

Updated by Gerrit Code Review over 7 years ago

Patch set 64 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #43

Updated by Riccardo De Contardi over 7 years ago

  • Target version changed from 8 LTS to 9.0
Actions #44

Updated by Riccardo De Contardi over 7 years ago

  • Target version changed from 9.0 to 8 LTS
Actions #45

Updated by Gerrit Code Review over 7 years ago

Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #46

Updated by Gerrit Code Review over 7 years ago

Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #47

Updated by Gerrit Code Review over 7 years ago

Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #48

Updated by Gerrit Code Review over 7 years ago

Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #49

Updated by Gerrit Code Review over 7 years ago

Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #50

Updated by Gerrit Code Review over 7 years ago

Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #51

Updated by Gerrit Code Review over 7 years ago

Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #52

Updated by Gerrit Code Review over 7 years ago

Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #53

Updated by Gerrit Code Review over 7 years ago

Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #54

Updated by Gerrit Code Review over 7 years ago

Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51514

Actions #55

Updated by Benni Mack about 7 years ago

  • Status changed from Under Review to Rejected
Actions #56

Updated by Riccardo De Contardi about 7 years ago

Actions

Also available in: Atom PDF