Bug #80416
closed
Imageorient icons not working with slow Internet connection
100%
Description
When opening an image or text&images content element with a slow connection, the icons below the dropdown of the imageorient selection are shown but do not work. When clicked the selection dont get applied.
The dropdown works properly.
The reason is located in the javascript file typo3_src/typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectSingleElement.js
The icons are used without checking beforehand if they are already loaded. So the icons do not get the onClick event when you have a slow connection.
You can check the behavior in chrome using the developer tools. In the network tab you can use the throttling functionality.
In my case the problem occurred with 'Regular 3G'.
Used TYPO3 Version is 7.6
Files
Updated by Frank Nägler over 7 years ago
- Status changed from New to In Progress
- Assignee set to Frank Nägler
Updated by Gerrit Code Review over 7 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52136
Updated by Frank Nägler over 7 years ago
@Tabea, I can't reproduce the problem but think I know what is wrong.
I have prepared a patch: https://review.typo3.org/#/c/52136/
please test if it fix the problem, I will provide the backport for 7.6 if you can confirm that the patch works.
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52136
Updated by Tabea Oertel over 7 years ago
- Assignee deleted (
Frank Nägler)
I tested the Patch and it does fix the problem.
But we should check the existance of the element in javascript too before registering any eventhandler on it. So we need an $selectElement.length check in SelectSingleElement.js.
Updated by Frank Nägler over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7a4814c2f20443dc4aae8eeea8d08ea02eb1af6c.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52143
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52143
Updated by Frank Nägler over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset c8a7743ae25e38180c922bc839a487c021619124.
Updated by