Project

General

Profile

Actions

Bug #80874

closed

QueryBuilder::quoteIdentifiersForSelect - No subselects possible

Added by Bastian Zagar almost 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Start date:
2017-04-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Hello,

the hardcore quoting in TYPO3\CMS\Core\Database\Query\QueryBuilder of all fields don't allow any subselects (e.g.) when using the hook at

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']["TYPO3\\CMS\\Recordlist\\RecordList\\DatabaseRecordList"]['buildQueryParameters']
because everything is quoted except the "*".

I am not sure if this is wanted but i am declaring this as a bug because subselects should be possible.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #81651: Hand over whole querybuilder object into list-modul hookClosedFrank Nägler2017-06-21

Actions
Actions #1

Updated by Bastian Zagar almost 7 years ago

Problem is found in

QueryBuilder::quoteIdentifiersForSelect

Actions #2

Updated by Benni Mack almost 7 years ago

  • Target version changed from 8 LTS to next-patchlevel
Actions #3

Updated by Julian Mair over 6 years ago

Is it not already possible to do exaclty that with QueryBuilder::selectLiteral and QueryBuilder::addSelectLiteral?

But nevertheless, for the 'FROM' clause it should be possible too ...
btw. even doctrine say, that we are not forced to quote everthing. In many cases they causing more problems than they solve...
@see: https://github.com/doctrine/dbal/blob/2.6/lib/Doctrine/DBAL/Connection.php#L806

Actions #4

Updated by Benni Mack almost 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #5

Updated by Susanne Moog about 4 years ago

  • Status changed from New to Closed

Fixed with #81651 - the complete $queryBuilder is now available and can be used / adjusted.

Actions #6

Updated by Susanne Moog about 4 years ago

  • Related to Task #81651: Hand over whole querybuilder object into list-modul hook added
Actions

Also available in: Atom PDF