Bug #81024
getFilenameFromMainDir() triggers PHP Warnings open_basedir
100%
Description
Method
\TYPO3\CMS\Core\Resource\ResourceCompressor::getFilenameFromMainDir()
triggers warnings
core: Core: Error handler (BE): PHP Warning: is_file(): open_basedir restriction in effect. File(/var/www/website/htdocs/../typo3conf/ext/extension/Resources/Public/file) is not within the allowed path(s):
when the BE is browsed.
This happens because "is_file($absolutePath)" checks outside the website root in the case of a passed file that has a relative path that begins with "../typo3conf/extension..." and open_basedir doesn't allow it.
Me and Markus Klein talked about the problem and decided to use the PHP error control operator @ to suppress the warnings because other solutions could break the code in other cases.
Related issues
Associated revisions
[BUGFIX] Ignore open_basedir warning for files outside the website root
Suppress warnings generated by getFilenameFromMainDir() when it needs
to check file paths outside the website root and open_basedir
is in effect.
Resolves: #81024
Releases: master, 8.7
Change-Id: Ia339c907577547374545c0a94393f698828523c7
Reviewed-on: https://review.typo3.org/52614
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
[BUGFIX] Ignore open_basedir warning for files outside the website root
Suppress warnings generated by getFilenameFromMainDir() when it needs
to check file paths outside the website root and open_basedir
is in effect.
Resolves: #81024
Releases: master, 8.7
Change-Id: Ia339c907577547374545c0a94393f698828523c7
Reviewed-on: https://review.typo3.org/52694
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
History
#1
Updated by Gerrit Code Review over 2 years ago
Updated by - Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52614
#2
Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52614
#3
Updated by Markus Klein over 2 years ago
Updated by - Duplicated by Bug #81115: TYPO3-Exception in BE-Log due to "PHP Warning: is_file(): open_basedir restriction in effect" added
#4
Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52614
#5
Updated by Stephan Großberndt over 2 years ago
Updated by - Due date set to 2016-11-28
- Start date changed from 2017-04-26 to 2016-11-28
- Follows Bug #78803: ResourceCompressor can't deal with paths relative to docroot added
#6
Updated by Markus Klein over 2 years ago
- Duplicates Bug #79218: ResourceCompressor.php PHP Warning: is_file(): open_basedir restriction in effect added
#7
Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52694
#8
Updated by Christian Toffolo over 2 years ago
Updated by - Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset aa2cd35ff07d690b9a4b71f79faa0af8dbd4de17.
#9
Updated by Riccardo De Contardi about 2 years ago
Updated by - Status changed from Resolved to Closed