Project

General

Profile

Actions

Bug #81618

closed

Formengine DataProvider TcaColumnsOverrides must be executed before TcaGroup

Added by Sascha Egerer over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2017-06-22
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:
Remote Sprint

Description

The FormDataProvider TcaColumnsOverrides must be executed before TcaGroup as the type of the field may be changed by TcaColumnsOverrides.
TcaGroup does some desctructable actions on the result array that msut only be done if the field is a group field. If the type is changed via TcaColumnsOverrides the data is already modified which ends up in a broken form (e.g. data cant be saved anymore and is lost after saving).

Adding a "filter" does also not work as the group provider is executed before the filter is registered.


        'filter' => [
            [
                'userFunc' => Vendor\\Extension\\MyClass::class . '->doFilter',
                'parameters' => [
                    'evaluateGender' => 'female',
                ],
            ],
        ],

Adding the dependency does currently end up in a cycle dependency.


Subtasks 1 (1 open0 closed)

Task #81682: Throw exception if somebody tries to override the field "type" via "columnsOverride"NewSascha Egerer2017-06-22

Actions
Actions #1

Updated by Sascha Egerer over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Christian Kuhn over 6 years ago

That's hard: the TcaGroup provider is needed for recordTypeValue, which is needed by ColumnsOverrides provider.

Actions #3

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53526

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53526

Actions #5

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53526

Actions #6

Updated by Sascha Egerer over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF