Bug #81618

Formengine DataProvider TcaColumnsOverrides must be executed before TcaGroup

Added by Sascha Egerer about 2 months ago. Updated 24 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2017-06-22
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:
Remote Sprint

Description

The FormDataProvider TcaColumnsOverrides must be executed before TcaGroup as the type of the field may be changed by TcaColumnsOverrides.
TcaGroup does some desctructable actions on the result array that msut only be done if the field is a group field. If the type is changed via TcaColumnsOverrides the data is already modified which ends up in a broken form (e.g. data cant be saved anymore and is lost after saving).

Adding a "filter" does also not work as the group provider is executed before the filter is registered.


        'filter' => [
            [
                'userFunc' => Vendor\\Extension\\MyClass::class . '->doFilter',
                'parameters' => [
                    'evaluateGender' => 'female',
                ],
            ],
        ],

Adding the dependency does currently end up in a cycle dependency.


Subtasks

Task #81682: Throw exception if somebody tries to override the field "type" via "columnsOverride"Under ReviewSascha Egerer

History

#1 Updated by Sascha Egerer about 2 months ago

  • Description updated (diff)

#2 Updated by Christian Kuhn about 2 months ago

That's hard: the TcaGroup provider is needed for recordTypeValue, which is needed by ColumnsOverrides provider.

#3 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53526

#4 Updated by Gerrit Code Review 24 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53526

Also available in: Atom PDF