Project

General

Profile

Actions

Bug #81805

closed

SaveToDatabase throws exception on single table

Added by Markus Hofmann over 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Form Framework
Target version:
-
Start date:
2017-07-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

While working with SaveToDatabaseFinisher I found out, the executeInternal() funtion doesn't work correctly.

Line 199 tests $this->options for existing an array.

After debugging I found the problem:

$this->options is always an array, the condition itself has to check for configuration of single or multiple database operations.
Therefore it is necessary to check for existence of the key 'table' for deciding if single or multiple configuration.

if (!is_array($this->options)) {

must be set to

if (isset($this->options['table'])) {

to check for correct handling. I think, this could made better, but this workaround works for me, because 'table' must been set all time.

Actions #1

Updated by Björn Jacob about 7 years ago

  • Sprint Focus set to Remote Sprint
Actions #2

Updated by Mathias Brodala about 7 years ago

  • Assignee set to Mathias Brodala
Actions #3

Updated by Mathias Brodala about 7 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Mathias Brodala about 7 years ago

  • Subject changed from SaveToDatabase finisher works wrong and throws warning to SaveToDatabase throws exception on single table
Actions #5

Updated by Gerrit Code Review about 7 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53969

Actions #6

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53982

Actions #7

Updated by Mathias Brodala about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF