Bug #81806

Unescaped value in FormEngine.removeOption selector query

Added by Pierrick Caillon about 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2017-07-05
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
JavaScript
Complexity:
easy
Is Regression:
Sprint Focus:
On Location Sprint

Description

I have a form field whose values comes from a list of subscribed classes for some roles.

The flexform TCA for this form field looks like that:

<providers>
    <TCEforms>
        <label>LLL:EXT:my_ext/Resources/Private/Language/locallang.xlf:flexform.sheets.general.providers</label>
        <config>
            <type>select</type>
            <itemsProcFunc>Vendor\MyExt\Flexform\Helper-&gt;renderProviderList</itemsProcFunc>
            <maxitems>100</maxitems>
            <size>4</size>
        </config>
    </TCEforms>
</providers>

The computed items list looks like:

[
    [ 'First provider', 'Vendor\\MyExt\\FirstProvider' ],
    [ 'Second provider', 'Vendor\\MyExt\\SecondProvider' ]
]

Manipulating the form element does not work well.

The issue is removing an element from the selected box is not working. After step by step debugging, it looks like the value $(this).attr('value') needs selector string escaping on line 569 of EXT:backend/Resources/Public/JavaScript/FormEngine.js.

Also affect 8 LTS. The affected code portion is the same. Only one line down.

Associated revisions

Revision 8f9729c6 (diff)
Added by Wolfgang Klinger about 2 years ago

[BUGFIX] Escape value in FormEngine.removeOption selector

Resolves: #81806
Releases: master, 8.7, 7.6
Change-Id: I1efc630a5579be8c8a1569667253f2572b9261ed
Reviewed-on: https://review.typo3.org/53499
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Benjamin Kluge <>
Tested-by: Benjamin Kluge <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Henning Liebe <>
Tested-by: Henning Liebe <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 193d6572 (diff)
Added by Wolfgang Klinger about 2 years ago

[BUGFIX] Escape value in FormEngine.removeOption selector

Resolves: #81806
Releases: master, 8.7, 7.6
Change-Id: I1efc630a5579be8c8a1569667253f2572b9261ed
Reviewed-on: https://review.typo3.org/53557
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision be38f089 (diff)
Added by Wolfgang Klinger almost 2 years ago

[BUGFIX] Escape value in FormEngine.removeOption selector

Resolves: #81806
Releases: master, 8.7, 7.6
Change-Id: I1efc630a5579be8c8a1569667253f2572b9261ed
Reviewed-on: https://review.typo3.org/53563
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 1cf77c84 (diff)
Added by Susanne Moog almost 2 years ago

[BUGFIX] Escape value in FormEngine.removeOption selector

Change-Id: I3373078a78cc65cd27fcff7d38ded5291cdc5f3b
Resolves: #81806
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53572
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Susanne Moog about 2 years ago

  • Tags set to JaáVht

#2 Updated by Susanne Moog about 2 years ago

  • Tags changed from JaáVht to JavaScript
  • Sprint Focus set to On Location Sprint

#3 Updated by Wolfgang Klinger about 2 years ago

  • Assignee set to Wolfgang Klinger

#4 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53499

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53557

#6 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53563

#8 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53572

#10 Updated by Anonymous almost 2 years ago

  • Status changed from Under Review to Resolved

#11 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF