Bug #81987

Make pageTree.backgroundColor recursive

Added by Bernhard Eckl about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2017-07-27
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The option pageTree.backgroundColor is really useful, but if you don’t have the defined page mounted but some subpages of that page in the page tree, the pages are not colored.


Related issues

Related to TYPO3 Core - Feature #36069: Implement context menu option to add background colors for branches Accepted 2012-04-14

Associated revisions

Revision 5519649d (diff)
Added by Guido S. over 1 year ago

[BUGFIX] Use pageTree.backgroundColor recursively

When a page is listed in the pageTree, the option
pageTree.backgroundColor is recursively checked and all
subpages get the backgroundColor.

Now with subpages as a mount, the backgroundColor of the
parent page is adopted.

Resolves: #81987
Releases: master, 8.7
Change-Id: I29d444da96d9d2038a4940896fd848bf42e43f47
Reviewed-on: https://review.typo3.org/56489
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision 440e0ba2 (diff)
Added by Frank Naegler over 1 year ago

[BUGFIX] Prevent PHP notice in TreeController

With #81987 we have introduced code, which could cause PHP notices.
This patch changes the check to prevent such notices.

Resolves: #85057
Related: #81987
Releases: master
Change-Id: I85e85501c2593b8abacac1d8296148d03d57f407
Reviewed-on: https://review.typo3.org/57019
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Tymoteusz Motylewski almost 2 years ago

This should be solved in current master (v9.0). Can you please confirm.

it's not yet solved

#2 Updated by Riccardo De Contardi over 1 year ago

  • Related to Feature #36069: Implement context menu option to add background colors for branches added

#3 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56489

#12 Updated by Guido S. over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF