Task #82131

GeneralUtility::makeInstance() should throw exception on unknown class

Added by Mathias Brodala about 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2017-08-18
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

GeneralUtility::makeInstance() should throw an exception if a class does not exist. This way you could get a proper stack trace which simplifies debugging a lot. ATM you get a fatal error instead which sometimes leads simply to blank pages instead of error messages.

Associated revisions

Revision 4bc4fb02 (diff)
Added by Mathias Brodala about 2 years ago

[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class

Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7
Resolves: #82131
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53731
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Daniel Goerz <>
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision a87bd76b (diff)
Added by Mathias Brodala about 2 years ago

[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class

Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7
Resolves: #82131
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53793
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision aeb543de (diff)
Added by Christian Kuhn about 2 years ago

Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac
Releases: master, 8.7
Resolves: #82131
Reverts: #82131
Reviewed-on: https://review.typo3.org/54004
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 161c1446 (diff)
Added by Christian Kuhn about 2 years ago

Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac
Releases: master, 8.7
Resolves: #82131
Reverts: #82131
Reviewed-on: https://review.typo3.org/54004
Reviewed-on: https://review.typo3.org/54010
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53793

#6 Updated by Mathias Brodala about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53793

#8 Updated by Mathias Brodala about 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Christian Kuhn about 2 years ago

  • Status changed from Resolved to Accepted

will be reverted.

#10 Updated by Mathias Brodala about 2 years ago

Christian Kuhn wrote:

will be reverted.

See post-merge comments in https://review.typo3.org/53731

#11 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54004

#12 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54010

#13 Updated by Christian Kuhn about 2 years ago

  • Status changed from Under Review to Resolved

#14 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF