Task #82131: GeneralUtility::makeInstance() should throw exception on unknown class - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Task #82131

closed

GeneralUtility::makeInstance() should throw exception on unknown class

Added by Mathias Brodala over 7 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Mathias Brodala

Category:

Target version:

9.0

Start date:

2017-08-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

GeneralUtility::makeInstance() should throw an exception if a class does not exist. This way you could get a proper stack trace which simplifies debugging a lot. ATM you get a fatal error instead which sometimes leads simply to blank pages instead of error messages.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53731

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53793

Actions

Copy link

Updated by Mathias Brodala over 7 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53793

Actions

Copy link

Updated by Mathias Brodala over 7 years ago

Status changed from Under Review to Resolved

Applied in changeset a87bd76b21f62b90b500283734fd5aa2c03e45c0.

Actions

Copy link

Updated by Christian Kuhn about 7 years ago

Status changed from Resolved to Accepted

will be reverted.

Actions

Copy link

#10

Updated by Mathias Brodala about 7 years ago

Christian Kuhn wrote:

will be reverted.

See post-merge comments in https://review.typo3.org/53731

Actions

Copy link

#11

Updated by Gerrit Code Review about 7 years ago

Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54004

Actions

Copy link

#12

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54010

Actions

Copy link

#13