Task #82445

Migrate Page Overlays into Pages table

Added by Benni Mack almost 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Localization
Target version:
Start date:
2017-09-10
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There are a lot of inconsistencies throuhgout the TYPO3 Core to deal with translations, one of the biggest the concept of pages that store translations in a separate DB table (pages_language_overlay), thus, carrying no information about the language.

In order to streamline the places that are affected by this difference to all other functionality, this should be in line with all other places.


Related issues

Related to TYPO3 Core - Bug #83082: Streamline page translation localization modes for enableFields Closed 2017-11-24
Related to TYPO3 Core - Bug #86547: doktype field is missing when creating a new page Closed 2018-10-02

Associated revisions

Revision 355be2e7 (diff)
Added by Benni Mack over 1 year ago

[!!!][TASK] Migrate pages_language_overlay into pages

The patch migrates all data from pages_language_overlay into pages,
and moves all API calls to overlay pages.

The following restrictions are set:
  • Backend is always showing pages only for "sys_language_uid=0"
    for the page tree, element browser (e.g. "linking to default
    language page"), except where explicitly requested like the Page
    Module => Languages view.
  • pid and sorting are always the same for all translations and
    their default language page
  • Elements on a page are always keeping the field "pid" to the
    default language page (no change)
  • Permission checks for Backend users are always made against
    the default language page (perms_* fields and webmounts)

Resolves: #82445
Releases: master
Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260
Reviewed-on: https://review.typo3.org/51272
Tested-by: TYPO3com <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision 54959380 (diff)
Added by Christian Kuhn over 1 year ago

[TASK] Update ext:styleguide to 9.0.0

The v9/master branch of styleguide generates correct
page localizations of styleguide demo data pages in
table pages instead of pages_language_overlay.

Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc
Resolves: #82952
Related: #82445
Releases: master
Reviewed-on: https://review.typo3.org/54592
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision b4767358 (diff)
Added by Benni Mack over 1 year ago

[FOLLOWUP][TASK] Migrate pages_language_overlay into pages

An additional SQL index is added to the database.

Resolves: #82445
Releases: master
Change-Id: I94d1eab5f492b465fafbf3620b0f532e1403be76
Reviewed-on: https://review.typo3.org/54591
Reviewed-by: Christian Kuhn <>
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 4e2f110d (diff)
Added by Andreas Fernandez 10 months ago

[BUGFIX] Omit `overrideVals` in NewRecordController

In the old times of pages_language_overlay, the "New Record" wizard
automatically re-used the doktype of the parent table which was `pages`.
Since pages_language_overlay vanished, the `overrideVals` in the links in
the wizard use the `pages` table.

This results in invalid value for `doktype` if a page in pid=0 is
created, as pid=0 has no doktype.

For this reason, the `overrideVals` parameter is removed.

Resolves: #86547
Related: #82445
Releases: master
Change-Id: I6efa699e5ef09eed6321ae68b5838682214376de
Reviewed-on: https://review.typo3.org/58561
Tested-by: TYPO3com <>
Tested-by: Guido Schmechel <>
Tested-by: Josef Glatz <>
Reviewed-by: Josef Glatz <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#16 Updated by Gerrit Code Review almost 2 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#17 Updated by Gerrit Code Review almost 2 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#18 Updated by Gerrit Code Review almost 2 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#19 Updated by Gerrit Code Review almost 2 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#20 Updated by Gerrit Code Review almost 2 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#21 Updated by Gerrit Code Review almost 2 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#22 Updated by Gerrit Code Review almost 2 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#23 Updated by Gerrit Code Review almost 2 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#24 Updated by Gerrit Code Review almost 2 years ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#25 Updated by Gerrit Code Review almost 2 years ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#26 Updated by Gerrit Code Review almost 2 years ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#27 Updated by Gerrit Code Review almost 2 years ago

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#28 Updated by Gerrit Code Review almost 2 years ago

Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#29 Updated by Gerrit Code Review almost 2 years ago

Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#30 Updated by Gerrit Code Review almost 2 years ago

Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#31 Updated by Gerrit Code Review almost 2 years ago

Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#32 Updated by Gerrit Code Review almost 2 years ago

Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#33 Updated by Gerrit Code Review almost 2 years ago

Patch set 55 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#34 Updated by Gerrit Code Review almost 2 years ago

Patch set 56 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#35 Updated by Gerrit Code Review almost 2 years ago

Patch set 57 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#36 Updated by Gerrit Code Review almost 2 years ago

Patch set 58 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#37 Updated by Gerrit Code Review almost 2 years ago

Patch set 59 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#38 Updated by Gerrit Code Review almost 2 years ago

Patch set 60 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#39 Updated by Gerrit Code Review almost 2 years ago

Patch set 61 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#40 Updated by Gerrit Code Review almost 2 years ago

Patch set 62 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#41 Updated by Gerrit Code Review almost 2 years ago

Patch set 63 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#42 Updated by Gerrit Code Review over 1 year ago

Patch set 64 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#43 Updated by Gerrit Code Review over 1 year ago

Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#44 Updated by Gerrit Code Review over 1 year ago

Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#45 Updated by Gerrit Code Review over 1 year ago

Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#46 Updated by Gerrit Code Review over 1 year ago

Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#47 Updated by Gerrit Code Review over 1 year ago

Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#48 Updated by Gerrit Code Review over 1 year ago

Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#49 Updated by Gerrit Code Review over 1 year ago

Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#50 Updated by Gerrit Code Review over 1 year ago

Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#51 Updated by Gerrit Code Review over 1 year ago

Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#52 Updated by Gerrit Code Review over 1 year ago

Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#53 Updated by Gerrit Code Review over 1 year ago

Patch set 75 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#54 Updated by Gerrit Code Review over 1 year ago

Patch set 76 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#55 Updated by Gerrit Code Review over 1 year ago

Patch set 77 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#56 Updated by Gerrit Code Review over 1 year ago

Patch set 78 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#57 Updated by Gerrit Code Review over 1 year ago

Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#58 Updated by Gerrit Code Review over 1 year ago

Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#59 Updated by Gerrit Code Review over 1 year ago

Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#60 Updated by Gerrit Code Review over 1 year ago

Patch set 82 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#61 Updated by Gerrit Code Review over 1 year ago

Patch set 83 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#62 Updated by Gerrit Code Review over 1 year ago

Patch set 84 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#63 Updated by Gerrit Code Review over 1 year ago

Patch set 85 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#64 Updated by Gerrit Code Review over 1 year ago

Patch set 86 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#65 Updated by Gerrit Code Review over 1 year ago

Patch set 87 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51272

#66 Updated by Benni Mack over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#67 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54591

#68 Updated by Benni Mack over 1 year ago

  • Status changed from Under Review to Resolved

#69 Updated by Christian Kuhn over 1 year ago

  • Related to Bug #83082: Streamline page translation localization modes for enableFields added

#70 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#71 Updated by Andreas Fernandez 10 months ago

  • Related to Bug #86547: doktype field is missing when creating a new page added

Also available in: Atom PDF