Bug #82743

Install Tool image tests do not work anymore since 81951

Added by Markus Klein about 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Install Tool
Target version:
Start date:
2017-10-12
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

While moving the entry point for the install tool to an upper level, it was overlooked that there are relative path specifications in a Fluid template.

Those paths are now wrong and hence the images for the im/gm tests are not displayed anymore.
This mistake is "hidden" if the instance is running in the document root as superfluous path traversals are ignored.


Related issues

Related to TYPO3 Core - Bug #81951: Move Install Tool entry point to typo3/install.php Closed 2017-07-24

Associated revisions

Revision 3d859316 (diff)
Added by Markus Klein about 1 year ago

[BUGFIX] Use correct path for test images in install tool

This resolves a regression to #81951, where the path adjustment
has been forgotten.

Resolves: #82743
Releases: 8.7
Change-Id: Ibd0260b0450e2b8d0078a004acf4ee835d6a34cc
Reviewed-on: https://review.typo3.org/54373
Reviewed-by: Johannes Kasberger <>
Tested-by: Johannes Kasberger <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

History

#1 Updated by Markus Klein about 1 year ago

  • Related to Bug #81951: Move Install Tool entry point to typo3/install.php added

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54373

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54373

#4 Updated by Helmut Hummel about 1 year ago

This mistake is "hidden" if the instance is running in the document root as superfluous path traversals are ignored.

Does this mean, that the bug is only triggered, when TYPO3 is installed in a sub directory?

#5 Updated by Markus Klein about 1 year ago

@Helmut: Yes exactly.

Former URL of install tool is typo3/sysext/install/Start/Install.php, hence the quad-path-upwards-traversal was correct.
Now we reside in typo3/install.php, hence 4x '../' is a bit too much. That does not hurt for installations in doc-root as the superfluous parts are simply discarded. But if the instance is in a subdirectory, you loose this information.

#6 Updated by Markus Klein about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF