Project

General

Profile

Actions

Bug #82743

closed

Install Tool image tests do not work anymore since 81951

Added by Markus Klein over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Install Tool
Target version:
Start date:
2017-10-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

While moving the entry point for the install tool to an upper level, it was overlooked that there are relative path specifications in a Fluid template.

Those paths are now wrong and hence the images for the im/gm tests are not displayed anymore.
This mistake is "hidden" if the instance is running in the document root as superfluous path traversals are ignored.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81951: Move Install Tool entry point to typo3/install.phpClosed2017-07-24

Actions
Actions #1

Updated by Markus Klein over 6 years ago

  • Related to Bug #81951: Move Install Tool entry point to typo3/install.php added
Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54373

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54373

Actions #4

Updated by Helmut Hummel over 6 years ago

This mistake is "hidden" if the instance is running in the document root as superfluous path traversals are ignored.

Does this mean, that the bug is only triggered, when TYPO3 is installed in a sub directory?

Actions #5

Updated by Markus Klein over 6 years ago

@Helmut: Yes exactly.

Former URL of install tool is typo3/sysext/install/Start/Install.php, hence the quad-path-upwards-traversal was correct.
Now we reside in typo3/install.php, hence 4x '../' is a bit too much. That does not hurt for installations in doc-root as the superfluous parts are simply discarded. But if the instance is in a subdirectory, you loose this information.

Actions #6

Updated by Markus Klein over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF