Task #82763

Move Fluid template pre-processor and expression node types registrations to TYPO3_CONF_VARS

Added by Claus Due over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2017-10-14
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

Currently these implementations are hardcoded into the TYPO3 CMS rendering context, which means the only ways to change these is to override the RenderingContext or use the public API of RenderingContext (which isn't always possible to do in TYPO3, e.g. FLUIDTEMPLATE doesn't really have any initialization methods you could use).

Moving these registrations to TYPO3_CONF_VARS allows extensions to add new such processor/expression types globally.

This new global registration will be vital to things like the frontend_editing extension to enable automatic editing of, for example, Extbase domain objects in any template instead of requiring template overrides which enable editing (such as it currently does).

Associated revisions

Revision b8f745f4 (diff)
Added by Claus Due about 2 years ago

[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54395
Tested-by: TYPO3com <>
Reviewed-by: Mattias Nilsson <>
Tested-by: Mattias Nilsson <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Jan Stockfisch <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

Revision 8766f367 (diff)
Added by Claus Due about 2 years ago

[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54581
Reviewed-by: Benni Mack <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54395

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54395

#3 Updated by Wouter Wolters over 2 years ago

  • Category set to Fluid

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54395

#5 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54581

#7 Updated by Stefan Neufeind about 2 years ago

Some details from Claus, as he wrote in the 8.7-review on gerrit:
[...]
As mentioned elsewhere, this is a pre-requisite for improving the Fluid integration in the frontend_editing extension in several ways, without requiring each extension to opt-in to such capabilities. See https://gist.github.com/NamelessCoder/9aca683920d9e4225f0527e0ce900ba8

It is highly critical at least for this one extension - and definitely useful for others as well, who do such overrides but prefer to keep them in static configuration.

#8 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54581

#9 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF